feat: fix redundant "first invented" / "invented for the first time"#3790
Open
hippietrail wants to merge 3 commits into
Open
feat: fix redundant "first invented" / "invented for the first time"#3790hippietrail wants to merge 3 commits into
hippietrail wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues
Fixes #1129
Description
Flags verbs that imply the first time redundantly used with the word "first":
Some verbs make this implication with much more certainty, while others depend more on the context, so the
messagevaries based on the verb.The current patterns only cover the examples from the GitHub issue rather than trying to cover a wide range of hypothetical patterns. Running this on the fuzzer could be quite helpful.
So the chance of false negatives is reasonable. File bugs or comment here for false positives and negatives.
How Has This Been Tested?
cargo testAI Disclosure
I asked some AI for some coding idea but wrote all the code here myself.
If Your PR Implements or Enhances a Linter
Checklist