Skip to content

Forms: update empty state to use component from wp-ui#47908

Merged
simison merged 6 commits into
trunkfrom
update/forms-empty-state
May 29, 2026
Merged

Forms: update empty state to use component from wp-ui#47908
simison merged 6 commits into
trunkfrom
update/forms-empty-state

Conversation

@simison
Copy link
Copy Markdown
Member

@simison simison commented Apr 2, 2026

Resolves FORMS-674

Proposed changes

  • Uses EmptyState recently added to wp-ui.
  • Adds icons to each empty state

No forms:
Screenshot 2026-05-29 at 18 07 54

No search results:
Screenshot 2026-05-29 at 17 51 25
Screenshot 2026-05-29 at 17 51 18

Responses folders:
Screenshot 2026-05-29 at 17 49 25
Screenshot 2026-05-29 at 17 49 31
Screenshot 2026-05-29 at 17 49 16

Since I'm touching block icon — it continues to work — materialIcon() doesn't do anything material anymore after it doesn't paint icons green:
Screenshot 2026-05-29 at 18 08 25

Other information

  • Generate changelog entries for this PR (using AI).

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Try empty forms lists and empty responses lists

@simison simison added Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Package] Forms labels Apr 2, 2026
Comment thread projects/packages/forms/package.json Outdated
"@wordpress/route": "0.8.0",
"@wordpress/theme": "0.9.0",
"@wordpress/ui": "0.9.0",
"@wordpress/ui": "0.10.0",
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally updated before this PR everywhere to the same version via #47907

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Apr 2, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 2, 2026

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack), and enable the update/forms-empty-state branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/forms-empty-state

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@jp-launch-control
Copy link
Copy Markdown

jp-launch-control Bot commented Apr 2, 2026

Code Coverage Summary

Coverage changed in 2 files.

File Coverage Δ% Δ Uncovered
projects/packages/forms/src/blocks/contact-form/index.js 0/16 (0.00%) 0.00% -1 💚
projects/packages/forms/src/dashboard/components/empty-responses/index.tsx 0/44 (0.00%) 0.00% -2 💚

1 file is newly checked for coverage.

File Coverage
projects/packages/forms/src/blocks/contact-form/icon.jsx 0/1 (0.00%) 💔

Full summary · PHP report · JS report

Coverage check overridden by I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. .

@simison simison force-pushed the update/forms-empty-state branch from 89c48e8 to 8adeb2e Compare April 3, 2026 14:26
@simison simison requested review from a team, dhasilva and enejb April 3, 2026 15:05
@simison
Copy link
Copy Markdown
Member Author

simison commented Apr 3, 2026

Still needs more work:

  • Form icon doesn't show up
  • The PR messes up Forms canvas styles somehow

@enejb
Copy link
Copy Markdown
Member

enejb commented Apr 3, 2026

I also notice on mobile it looks like this.

Screenshot 2026-04-03 at 4 22 17 PM

But didn't dig in why.

@simison simison force-pushed the update/forms-empty-state branch from 8adeb2e to d6af659 Compare April 6, 2026 07:21
@enejb enejb force-pushed the update/forms-empty-state branch from d6af659 to 5cdbba8 Compare April 10, 2026 16:47
@simison simison force-pushed the update/forms-empty-state branch from 5cdbba8 to c184885 Compare May 28, 2026 07:20
@simison simison marked this pull request as ready for review May 28, 2026 07:33
@simison simison force-pushed the update/forms-empty-state branch from bd4bd3e to f60757c Compare May 28, 2026 07:45
@simison simison force-pushed the update/forms-empty-state branch from f60757c to ced1897 Compare May 29, 2026 14:20
@simison simison added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 29, 2026
@simison simison added Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change. and removed [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. labels May 29, 2026
@simison
Copy link
Copy Markdown
Member Author

simison commented May 29, 2026

@enejb I tested and looks good now:

image

@simison simison added the I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. label May 29, 2026
@simison
Copy link
Copy Markdown
Member Author

simison commented May 29, 2026

The forms icon optically reads smaller and “tighter” even though the SVG box and the container are the same size (24px icon, 34px circle):

image image

I think it's fine for this PR but flagging @ilonagl if you have ideas!

Copy link
Copy Markdown
Contributor

@CGastrell CGastrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Worked nicely on all empty states! :shipit:

@simison simison merged commit ccd895f into trunk May 29, 2026
81 of 82 checks passed
@simison simison deleted the update/forms-empty-state branch May 29, 2026 19:26
@github-actions github-actions Bot removed the [Status] Needs Review This PR is ready for review. label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Block] Contact Form Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Contact Form I don't care about code coverage for this PR Use this label to ignore the check for insufficient code coveage. [Package] Forms Reviewer Can Merge PR author indicates the reviewer is free to merge/deploy if they want to own the change.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants