Forms: update empty state to use component from wp-ui#47908
Conversation
| "@wordpress/route": "0.8.0", | ||
| "@wordpress/theme": "0.9.0", | ||
| "@wordpress/ui": "0.9.0", | ||
| "@wordpress/ui": "0.10.0", |
There was a problem hiding this comment.
Ideally updated before this PR everywhere to the same version via #47907
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! |
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 2 files.
1 file is newly checked for coverage.
Full summary · PHP report · JS report Coverage check overridden by
I don't care about code coverage for this PR
|
89c48e8 to
8adeb2e
Compare
|
Still needs more work:
|
8adeb2e to
d6af659
Compare
d6af659 to
5cdbba8
Compare
5cdbba8 to
c184885
Compare
bd4bd3e to
f60757c
Compare
f60757c to
ced1897
Compare
|
@enejb I tested and looks good now:
|
|
The forms icon optically reads smaller and “tighter” even though the SVG box and the container are the same size (24px icon, 34px circle):
I think it's fine for this PR but flagging @ilonagl if you have ideas! |
CGastrell
left a comment
There was a problem hiding this comment.
LGTM! Worked nicely on all empty states! ![]()




Resolves FORMS-674
Proposed changes
No forms:

No search results:


Responses folders:



Since I'm touching block icon — it continues to work —

materialIcon()doesn't do anything material anymore after it doesn't paint icons green:Other information
Related product discussion/links
Does this pull request change what data or activity we track or use?
Testing instructions