Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
103 changes: 0 additions & 103 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 0 additions & 24 deletions projects/js-packages/base-styles/admin-page-layout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -196,35 +196,11 @@ $jp-breakpoint-mobile: 782px;
// (dashboard grids with fixed column widths, wide tables, `100vw`
// descendants) scroll horizontally inside the middle instead of
// dragging the whole window into a horizontal scrollbar.

// `<AdminPage>` (title-branch) wraps children in
// `<Container fluid horizontalSpacing={0}><Col>{children}</Col></Container>`
// — that outer Container is `display: grid` and the single Col is a
// grid cell. Without intervention, the chain breaks here: any inner
// flex sizing on the consumer's wrapper (`flex: 1 1 auto; min-height: 0`)
// is inert under a non-flex parent, so DataViews-style pages let their
// content grow to its natural size and the outer Container scrolls
// the whole thing — instead of letting the consumer's own internal
// scroll surface (e.g. `.dataviews-layout__container`) handle it.
// Force the outer Container/Col pair to flex column so consumers can
// fill their bounded slot. Form-style pages keep working: their
// children stay content-sized (default `flex: 0 1 auto`) and any
// overflow still falls back to Container's `overflow: auto`.
.admin-ui-page > :not(.admin-ui-page__header):not(.jetpack-footer) {
flex: 1 1 auto;
min-height: 0;
min-width: 0;
overflow: auto;
display: flex;
flex-direction: column;

> * {
flex: 1 1 auto;
min-height: 0;
min-width: 0;
display: flex;
flex-direction: column;
}
}

// ── <JetpackFooter> pinned at the bottom ─────────────────────────
Expand Down

This file was deleted.

This file was deleted.

11 changes: 3 additions & 8 deletions projects/js-packages/components/components/admin-page/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,6 @@ const AdminPage: FC< AdminPageProps > = ( {
breadcrumbs,
tabs,
showBottomBorder = true,
unwrapped = false,
} ) => {
useEffect( () => {
restApi.setApiRoot( apiRoot );
Expand Down Expand Up @@ -96,13 +95,9 @@ const AdminPage: FC< AdminPageProps > = ( {
showSidebarToggle={ false }
>
{ tabs }
{ unwrapped ? (
children
) : (
<Container fluid horizontalSpacing={ 0 }>
<Col>{ children }</Col>
</Container>
) }
<Container fluid horizontalSpacing={ 0 }>
<Col>{ children }</Col>
</Container>
{ showFooter && <JetpackFooter menu={ optionalMenuItems } /> }
</Page>
</div>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,4 @@ export type AdminPageProps = {
* Hidden when `tabs` is used.
*/
showBottomBorder?: boolean;

/**
* Render `children` directly inside the admin-ui Page, skipping the
* default `<Container fluid horizontalSpacing={0}><Col>{children}</Col></Container>`
* wrap. Use for full-bleed pages (DataViews-based admin surfaces, full-app
* dashboards) that own their own scroll/layout model and don't want the
* outer Container's grid to break their flex chain. Defaults to `false`.
*/
unwrapped?: boolean;
};
15 changes: 0 additions & 15 deletions projects/packages/activity-log/.gitattributes

This file was deleted.

6 changes: 0 additions & 6 deletions projects/packages/activity-log/.gitignore

This file was deleted.

13 changes: 0 additions & 13 deletions projects/packages/activity-log/.phan/config.php

This file was deleted.

24 changes: 0 additions & 24 deletions projects/packages/activity-log/.phpcs.dir.xml

This file was deleted.

33 changes: 0 additions & 33 deletions projects/packages/activity-log/AGENTS.md

This file was deleted.

10 changes: 0 additions & 10 deletions projects/packages/activity-log/CHANGELOG.md

This file was deleted.

15 changes: 0 additions & 15 deletions projects/packages/activity-log/README.md

This file was deleted.

10 changes: 0 additions & 10 deletions projects/packages/activity-log/babel.config.js

This file was deleted.

Empty file.
4 changes: 0 additions & 4 deletions projects/packages/activity-log/changelog/add-package-scaffold

This file was deleted.

This file was deleted.

Loading
Loading