Activity Log: default to Table layout and fix free-tier upsell layout#48417
Activity Log: default to Table layout and fix free-tier upsell layout#48417ilonagl wants to merge 1 commit into
Conversation
- Flip DEFAULT_VIEW.type from 'activity' to 'table' so new visitors land on the Date / Event / User columns instead of the timeline. Existing localStorage-persisted views are preserved by usePersistentView. - Forward upsell-callout.scss from the main entry style.scss via @use instead of relying on the side-effect import in UpsellCallout.tsx, so the rules land in the same chunk as the wrapper styles and the flex layout (image left, copy right on >= 782px) actually applies. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
|
Closed by branch rename — superseded by #48418 with identical content. |
Code Coverage SummaryThis PR did not change code coverage! That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷 |
Follow-up to #48244.
Proposed changes
DEFAULT_VIEW.typewas'activity'; flip it to'table'and use the table-sidefields/layoutalready declared inDEFAULT_LAYOUTS.table. Existing visitors keep whatever they had —usePersistentViewonly falls back to the new default for fresh sessions or after the user clicks "Reset view".UpsellCalloutwas rendering with the illustration on top of the copy (default block flow) instead of the side-by-side row layoutupsell-callout.scssprescribes. Forward the stylesheet from the main entrystyle.scssvia@useso the rules ride the same chunk as the wrapper styles (DataViews CSS,.jp-activity-log__dataviews-wrapper, etc.) instead of relying on a side-effectimportfromUpsellCallout.tsxthat wasn't reaching the deployed bundle. The JS-sideimportis dropped to avoid a double emit.Related product discussion/links
client/dashboard/sites/logs-activity/Does this pull request change what data or activity we track or use?
No.
Testing instructions
Setup: pull this branch,
jetpack install plugins/jetpack,jetpack build packages/activity-log. Visitadmin.php?page=jetpack-activity-logon a Jetpack-connected, non-multisite,manage_optionsuser.Default layout — paid tier (Backup-enabled site):
jetpack-activity-log:view:*entry (or use a fresh browser profile).Default layout — free tier (no Backup plan, e.g. fresh JN site):
<DataViews.Layout />), pagination is absent, and the table caps at 20 rows.Upsell callout layout (free tier, viewport ≥ 782px):
.jp-activity-log__upsell-calloutand confirmdisplay: flexandflex-direction: row(orcolumn-reverseon narrow viewports) are computed — i.e. the rules fromupsell-callout.scssreach the page.Regression spot-checks (existing PR #48244 behavior):
Apr 30, 2026) still render when the user explicitly switches to that layout via the cog.