-
Notifications
You must be signed in to change notification settings - Fork 881
AdminPage: restore layout overrides for @wordpress/admin-ui 2.0.0 #48423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
CGastrell
wants to merge
28
commits into
update/admin-ui
from
update/jetpack-page-layout-admin-ui-2x
Closed
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4d46a79
Update dependency @wordpress/build to v0.13.0 (#48403)
matticbot 8aec736
fix: change category picker icon from gear to tag for clarity (#48391)
allilevine 49ea70e
Write: Keep selected text highlighted while the link popover is open …
allilevine da72ce5
CRM: Address listview count string replace mismatch (#48396)
tbradsha b1cb072
Activity Log: Port AL into wp-admin as a native page (#48244)
keoshi e33dc09
Protect: migrate firewall upgrade prompt button to @wordpress/ui (#48…
lezama 6985c0f
CRM: migrate workflow row Edit button to @wordpress/ui (#48149)
lezama 253c242
CRM: Allow tag export on objects (#48364)
tbradsha 7dfefae
Protect: migrate admin page tabs to @wordpress/ui Tabs (#48277)
CGastrell 3780d70
Components: Migrate remaining Notice consumers to @wordpress/ui (#48173)
vianasw 7b9e261
VideoPress: fix runaway render loop on admin library pagination (#48411)
obenland ed0a3f8
Write: Add autosave with dirty state tracking and draft recovery (#48…
allilevine 944fb30
Write editor: fix drag-and-drop image upload in image modal (#48393)
allilevine 016eaee
Write: fix image captions not saved to block content (#48395)
allilevine 9387bec
CRM: Harden Mail Delivery settings permissions (#48359)
tbradsha b30a42e
CRM: Restrict some contact functions to admins (#48358)
tbradsha 2165304
Newsletter abilities: register get-settings + update-settings via Reg…
enejb 4814cae
Write: Prevent editing post content while image/video modal is open (…
allilevine fb3891f
Stats: register jetpack-stats abilities (#48286)
enejb 37f6199
Fix heading hierarchy in search overlay (#27947) (#48245)
CodeAllNightNDay 3529a1b
[WIP] Search 3.0: store/api helpers for product-shaped filters (wc_st…
kangzj 4e7294d
Search: fix hero section crushed under shared admin-page layout mixin…
adamwoodnz 4a57d33
phan: Update wpcom stubs (#48442)
matticbot f6f167a
Update admin-ui package and use visual prop for Jetpack logo
simison 3b4f6ce
changelogs
simison dc9b0d1
AdminPage: restore layout overrides for @wordpress/admin-ui 2.0.0
CGastrell b4915e4
Changelog: use Jetpack plugin Type enum (bugfix)
CGastrell a04967b
Use default heading level 1
simison File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/js-packages/base-styles/changelog/add-admin-page-tabs-mixin-rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| admin-page-layout mixin: style hooks for `@wordpress/ui` Tabs hosted in an AdminPage (sticky `.jp-admin-page-tabs` wrapper, inline-padding alignment for tab buttons, header bottom-border/padding suppression when tabs are present). |
4 changes: 4 additions & 0 deletions
4
projects/js-packages/base-styles/changelog/admin-page-layout-flex-children
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: changed | ||
|
|
||
| admin-page-layout mixin: extend the flex chain into AdminPage's outer Container/Col so DataViews-style consumers can fill their bounded slot and let their own internal scroll handle the table body. |
4 changes: 4 additions & 0 deletions
4
projects/js-packages/base-styles/changelog/jetpack-page-layout-admin-ui-2x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: fixed | ||
|
|
||
| admin-page-layout mixin: anchor selectors to the new `.jp-admin-page__page` className and the rendered `<header>` element, replacing the `.admin-ui-page*` global classes that admin-ui 2.0.0 dropped when it moved to CSS Modules. Restores the viewport-fitted scroll chain on every consumer (Boost, Protect, VideoPress, Search, Newsletter, Publicize, Backup, Jetpack network admin). |
4 changes: 4 additions & 0 deletions
4
projects/js-packages/components/changelog/add-toggle-control-aria-label
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| ToggleControl: forward the `aria-label` prop to the underlying checkbox so consumers can label toggles that have no visible label. |
4 changes: 4 additions & 0 deletions
4
projects/js-packages/components/changelog/admin-page-add-unwrapped-prop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: minor | ||
| Type: added | ||
|
|
||
| AdminPage: add `unwrapped` prop to render children directly inside the admin-ui Page, skipping the default Container/Col grid wrap. Use for full-bleed pages (DataViews-based admin surfaces) that own their own scroll/layout model. |
4 changes: 4 additions & 0 deletions
4
projects/js-packages/components/changelog/jetpack-page-layout-admin-ui-2x
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: fixed | ||
|
|
||
| AdminPage: pass a stable `jp-admin-page__page` className to admin-ui's Page so layout overrides survive admin-ui 2.0.0's switch to CSS Modules; pin the header heading level to `<h2>` and center the new `visual` slot to keep the Jetpack logo aligned with the title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: changed | ||
|
|
||
| AdminPage: Update to @wordpress/admin-ui 2.0.0 and use the new `visual` prop to render the Jetpack logo alongside the page title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
projects/js-packages/webpack-config/changelog/update-admin-ui
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| Significance: patch | ||
| Type: changed | ||
|
|
||
| Remove the @wordpress/admin-ui CSS bundle workaround from the default request map. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Files not needed to be distributed. | ||
| .babelrc export-ignore | ||
| .gitattributes export-ignore | ||
| .github/ export-ignore | ||
| .gitignore export-ignore | ||
|
|
||
| # Files not needed in the production build. | ||
| .phpcs.dir.xml production-exclude | ||
| /changelog/** production-exclude | ||
| /tests/** production-exclude | ||
| types.d.ts production-exclude | ||
| /src/js/** production-exclude | ||
|
|
||
| # Files needed in the production build. | ||
| build/** production-include |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| wordpress | ||
| node_modules | ||
| vendor | ||
| jetpack_vendor | ||
| .cache | ||
| build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| <?php | ||
| /** | ||
| * This configuration will be read and overlaid on top of the | ||
| * default configuration. Command-line arguments will be applied | ||
| * after this file is read. | ||
| * | ||
| * @package automattic/jetpack-activity-log | ||
| */ | ||
|
|
||
| // Require base config. | ||
| require __DIR__ . '/../../../../.phan/config.base.php'; | ||
|
|
||
| return make_phan_config( dirname( __DIR__ ) ); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| <?xml version="1.0"?> | ||
| <ruleset> | ||
|
|
||
| <rule ref="WordPress.WP.I18n"> | ||
| <properties> | ||
| <property name="text_domain" type="array"> | ||
| <element value="jetpack-activity-log" /> | ||
| </property> | ||
| </properties> | ||
| </rule> | ||
| <rule ref="Jetpack.Functions.I18n"> | ||
| <properties> | ||
| <property name="text_domain" value="jetpack-activity-log" /> | ||
| </properties> | ||
| </rule> | ||
|
|
||
| <rule ref="WordPress.Utils.I18nTextDomainFixer"> | ||
| <properties> | ||
| <property name="old_text_domain" type="array" /> | ||
| <property name="new_text_domain" value="jetpack-activity-log" /> | ||
| </properties> | ||
| </rule> | ||
|
|
||
| </ruleset> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,33 @@ | ||
| # Activity Log | ||
|
|
||
| ## UI primitives | ||
|
|
||
| When adding React UI in this package, prefer the WordPress Design System | ||
| packages in this order: | ||
|
|
||
| 1. **`@wordpress/ui`** — foundational primitives. Check each component's | ||
| Storybook "Status" badge (anything other than "stable" is still in | ||
| flux); avoid experimental APIs here. | ||
| 2. **`@wordpress/components`** — general-purpose legacy library. | ||
| Predates the design system. Use only when `@wordpress/ui` doesn't | ||
| have a stable equivalent, and still check Status in Storybook. | ||
| 3. **`@wordpress/dataviews`** — higher-level data presentation (tables, | ||
| lists, grids). Already the backbone here. Extend via its | ||
| sub-components (`DataViews.Search`, `DataViews.FiltersToggle`, | ||
| `DataViews.Layout`, `DataViews.Footer`) before reaching for lower- | ||
| level primitives. | ||
| 4. **`@wordpress/admin-ui`** — page layout primitives, accessed via | ||
| `AdminPage` from `@automattic/jetpack-components` (which wraps | ||
| admin-ui's `Page`). | ||
|
|
||
| Rationale: WordPress is moving new work to `@wordpress/ui`; | ||
| `@wordpress/components` is being kept as a legacy fallback. Guidance | ||
| from the WordPress Design System P2 (April 2026). | ||
|
|
||
| ## Design-system lookup | ||
|
|
||
| A dedicated MCP server is wired into this project's local Claude Code | ||
| config: `@wordpress/design-system-mcp`. It exposes the authoritative | ||
| list of stable `@wordpress/ui` + `@wordpress/components` components and | ||
| `--wpds-*` design tokens. Prefer querying it over spelunking through | ||
| `node_modules/@wordpress/components/src/**` for component metadata. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| # Changelog | ||
|
|
||
| All notable changes to this project will be documented in this file. | ||
|
|
||
| The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) | ||
| and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html). | ||
|
|
||
| ## 0.1.0-alpha - unreleased | ||
|
|
||
| Initial release. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you're bringing in a bunch of other PRs along with this PR now (e.g. this is from #48442). That seems likely to get confusing later.