Normalize page tabs onto shared minimal variant by CGastrell · Pull Request #48964 · Automattic/jetpack

CGastrell · 2026-05-19T14:35:49Z

Proposed changes

Normalize all page-level <Tabs.List> usages in Jetpack admin pages onto <Tabs.List variant="minimal"> + the shared .jp-admin-page-tabs--minimal wrapper modifier shipped in #48908. Delete the local SCSS blocks that were re-implementing what the new shared modifier now provides, plus the legacy default-variant alignment workarounds.

Scan / Newsletter / Search: were already variant="minimal" but each had a local SCSS block re-implementing what the new shared modifier does — local blocks deleted.
Protect / VideoPress: migrated from default → minimal variant. VideoPress also had a 16-line workaround in DashboardLayout/style.scss specifically to hold default-variant tabs aligned with the page header — deleted, since minimal removes the need entirely.
Newsletter additionally drops its bespoke wrapper class jetpack-newsletter-page__tabs-row in favour of the shared jp-admin-page-tabs jp-admin-page-tabs--minimal.

Diff stat: +27 / -77 lines (13 files, 5 of them changelog entries).

Related product discussion/links

Issue: Jetpack UI Modernization #48160 (Jetpack UI Modernization)
Shared modifier: Podcast: align Stats tab padding #48908 (Rob Pugh, merged 2026-05-18) introduced .jp-admin-page-tabs--minimal in admin-page-layout.scss.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

With this branch built (pnpm jetpack build packages/search packages/scan packages/newsletter packages/videopress plugins/protect), open the affected admin pages and confirm the page-level tab strip renders with the minimal variant (text-only labels, no rounded pill, tabs flush with the page title's start edge):
- Search — Plan & Usage / Settings / AI Answers (Preview)
- Newsletter — Subscribers / Settings (gated behind rsm_jetpack_ui_modernization_newsletter filter)
- Protect — Scan / Firewall / Settings
- VideoPress — Overview / Library / Settings (gated behind rsm_jetpack_ui_modernization_videopress filter)
- Scan (optional) — Active threats / History (gated behind rsm_jetpack_ui_modernization_scan filter)
Verify the first tab's text content edge lines up with the page header title at all widths.
Switch between tabs and confirm the active-tab indicator slides smoothly (Tabs.List keeps width: fit-content via the shared wrapper).
Confirm there are no console errors related to layout/CSS on any of the pages above.

Biggest visual deltas expected on Protect and VideoPress (both migrating default → minimal variant).

Out of scope (intentionally)

The following are not migrated in this PR — flagging so reviewers know what's deliberately excluded:

projects/plugins/jetpack/_inc/client/components/settings-nav-tabs/index.jsx — legacy settings page doesn't use AdminPage / the shared mixin yet. Waiting on PoC try: Reimplement Jetpack settings with @wordpress/ui (PoC, do not merge) #48181.
5 sub-strip / modal variant="minimal" consumers in Forms + the Newsletter add-subscribers-modal — they don't sit at the page-header edge, so wrapper alignment isn't needed.
projects/packages/videopress/src/client/admin/components/edit-video-details/index.tsx — separate slice (double-logo fix), tracked in a parallel PR.

Screenshots

Before/after captures for the 4 visible admin pages (and Scan, captured with the modernization filter toggled locally). All shots at 1440×900.

Page	Before	After
Search
Newsletter
Protect
VideoPress
Scan

github-actions · 2026-05-19T14:37:14Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

github-actions · 2026-05-19T14:38:10Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the chore/normalize-jetpack-tabs-minimal-variant branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack chore/normalize-jetpack-tabs-minimal-variant

bin/jetpack-downloader test jetpack-mu-wpcom-plugin chore/normalize-jetpack-tabs-minimal-variant

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

jp-launch-control · 2026-05-19T14:53:46Z

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Migrate all page-level Tabs.List usages in Jetpack admin pages onto <Tabs.List variant="minimal"> + the shared .jp-admin-page-tabs--minimal wrapper modifier shipped in #48908. Delete the local SCSS blocks that were re-implementing what the new shared modifier now provides, plus the legacy default-variant alignment workarounds. - Scan / Newsletter / Search: were already variant="minimal" but each had a local SCSS block re-implementing the new shared modifier. - Protect / VideoPress: migrated from default to minimal variant. VideoPress had a 16-line workaround in DashboardLayout/style.scss specifically to hold default-variant tabs aligned with the page header — deleted, since minimal removes the need. - Newsletter also dropped its bespoke wrapper class jetpack-newsletter-page__tabs-row in favour of the shared jp-admin-page-tabs jp-admin-page-tabs--minimal. Refs #48160.

Verify the tabs normalization compiles cleanly against the 0.13 release. Bumps the five packages this PR touches: - packages/search (0.12.0 → 0.13.0) - packages/scan (0.11.0 → 0.13.0) - packages/newsletter (0.11.0 → 0.13.0) - packages/videopress (0.11.0 → 0.13.0) - plugins/protect (0.11.0 → 0.13.0) Plus the per-route package.json files under scan, newsletter, and videopress. Other Jetpack projects remain on 0.11.0 — the monorepo-wide bump is the scope of the foundation PR #48404 (in flight).

CGastrell · 2026-05-19T16:12:32Z

cc @dhasilva @kangzj @robertbpugh since you were dealing with VideoPress, Search and Podcast pages

dhasilva

LGTM :magnifique:

* Normalize page tabs onto shared minimal variant Migrate all page-level Tabs.List usages in Jetpack admin pages onto <Tabs.List variant="minimal"> + the shared .jp-admin-page-tabs--minimal wrapper modifier shipped in #48908. Delete the local SCSS blocks that were re-implementing what the new shared modifier now provides, plus the legacy default-variant alignment workarounds. - Scan / Newsletter / Search: were already variant="minimal" but each had a local SCSS block re-implementing the new shared modifier. - Protect / VideoPress: migrated from default to minimal variant. VideoPress had a 16-line workaround in DashboardLayout/style.scss specifically to hold default-variant tabs aligned with the page header — deleted, since minimal removes the need. - Newsletter also dropped its bespoke wrapper class jetpack-newsletter-page__tabs-row in favour of the shared jp-admin-page-tabs jp-admin-page-tabs--minimal. Refs #48160. * Bump @wordpress/ui to 0.13.0 across affected packages Verify the tabs normalization compiles cleanly against the 0.13 release. Bumps the five packages this PR touches: - packages/search (0.12.0 → 0.13.0) - packages/scan (0.11.0 → 0.13.0) - packages/newsletter (0.11.0 → 0.13.0) - packages/videopress (0.11.0 → 0.13.0) - plugins/protect (0.11.0 → 0.13.0) Plus the per-route package.json files under scan, newsletter, and videopress. Other Jetpack projects remain on 0.11.0 — the monorepo-wide bump is the scope of the foundation PR #48404 (in flight).

CGastrell added the [Status] In Progress label May 19, 2026

github-actions Bot added [Package] Newsletter [Package] Scan [Package] Search Contains core Search functionality for Jetpack and Search plugins [Package] VideoPress [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. labels May 19, 2026

CGastrell self-assigned this May 19, 2026

CGastrell marked this pull request as ready for review May 19, 2026 15:09

CGastrell force-pushed the chore/normalize-jetpack-tabs-minimal-variant branch from 3bd9c1b to 61340f7 Compare May 19, 2026 15:11

CGastrell added [Status] Needs Review This PR is ready for review. and removed [Status] In Progress labels May 19, 2026

dhasilva approved these changes May 19, 2026

View reviewed changes

CGastrell merged commit 36293c9 into trunk May 19, 2026
125 of 128 checks passed

CGastrell deleted the chore/normalize-jetpack-tabs-minimal-variant branch May 19, 2026 20:19

github-actions Bot removed the [Status] Needs Review This PR is ready for review. label May 19, 2026

Copilot AI mentioned this pull request May 21, 2026

Port Search package 7.0.0 changes back to trunk #49029

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Normalize page tabs onto shared minimal variant#48964

Normalize page tabs onto shared minimal variant#48964
CGastrell merged 2 commits into
trunkfrom
chore/normalize-jetpack-tabs-minimal-variant

CGastrell commented May 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 19, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 19, 2026 •

edited

Loading

Uh oh!

jp-launch-control Bot commented May 19, 2026 •

edited

Loading

Uh oh!

CGastrell commented May 19, 2026

Uh oh!

dhasilva left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

CGastrell commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Out of scope (intentionally)

Screenshots

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control Bot commented May 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

CGastrell commented May 19, 2026

Uh oh!

dhasilva left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

CGastrell commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

github-actions Bot commented May 19, 2026 •

edited

Loading

jp-launch-control Bot commented May 19, 2026 •

edited

Loading