Skip to content

AdminPage: keep header-height rule matching on admin-ui 2.1 #49101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dhasilva merged 1 commit into from
May 22, 2026
Merged

AdminPage: keep header-height rule matching on admin-ui 2.1 #49101

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/js-packages/components/changelog/fix-admin-page-header-height-admin-ui-2-1
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

AdminPage: fix header-height tab-shift rule not matching after admin-ui 2.1 changed the page header element from header to div
4 changes: 3 additions & 1 deletion projects/js-packages/components/components/admin-page/style.module.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@
// row's items so a shorter control neither stretches nor collapses it.
// The content row is identified by the visual logo slot it contains
// (`aria-hidden="true"`), so a breadcrumbs-only header isn't affected.
:global(.jp-admin-page__page > header > div:has([aria-hidden="true"])) {
// `> :first-child` targets the page header positionally (a `<div>` in
// admin-ui ≥ 2.1, a `<header>` in 2.0) — matching the sibling rules above.
:global(.jp-admin-page__page > :first-child > div:has([aria-hidden="true"])) {
min-height: 40px;
align-items: center;
}
Expand Down
Loading