Skip to content

feat(premium-analytics): resolve internal packages for build and types #49189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chihsuan wants to merge 7 commits into
base: trunk
Choose a base branch
from
+20 −2
Open

feat(premium-analytics): resolve internal packages for build and types #49189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
00fed2d
feat(premium-analytics): add tsconfig paths and typecheck for interna…
chihsuan May 27, 2026
20e6241
Potential fix for pull request finding
chihsuan May 27, 2026
662c887
Potential fix for pull request finding
chihsuan May 27, 2026
d4da9ca
docs(premium-analytics): clarify internal-package naming and rename init
chihsuan May 28, 2026
528458b
Merge branch 'trunk' into wooa7s-1320-configure-workspace-and-typescr…
chihsuan Jun 2, 2026
feeb212
docs(premium-analytics): revert internal-packages README section
chihsuan Jun 3, 2026
2beeaa9
fix(premium-analytics): align route name with internal-package conven…
chihsuan Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 4 additions & 0 deletions projects/packages/premium-analytics/changelog/add-internal-package-resolution
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: added

Add a tsconfig paths alias and typecheck script so internal packages/* resolve for types/IDE.
2 changes: 2 additions & 0 deletions projects/packages/premium-analytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
"scripts": {
"build": "wp-build && mkdir -p build/modules/boot && cp shims/boot-asset.php build/modules/boot/index.min.asset.php",
"build-production": "NODE_ENV=production wp-build && mkdir -p build/modules/boot && cp shims/boot-asset.php build/modules/boot/index.min.asset.php",
"typecheck": "tsgo --noEmit",
"watch": "wp-build --watch"
},
"wpPlugin": {
Expand Down Expand Up @@ -38,6 +39,7 @@
},
"devDependencies": {
"@babel/core": "7.29.0",
"@typescript/native-preview": "7.0.0-dev.20260225.1",
"@wordpress/build": "0.14.0",
"browserslist": "4.28.2"
}
Expand Down
2 changes: 1 addition & 1 deletion projects/packages/premium-analytics/packages/init/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "_@jetpack-premium-analytics/init",
"name": "@automattic/jetpack-premium-analytics-init",
"version": "0.1.0",
"type": "module",
"wpScript": true,
Expand Down
2 changes: 1 addition & 1 deletion projects/packages/premium-analytics/routes/dashboard/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"private": true,
"name": "_@jetpack-premium-analytics/dashboard-route",
"name": "@automattic/jetpack-premium-analytics-dashboard-route",
"route": {
"path": "/",
"page": "jetpack-premium-analytics"
Expand Down
9 changes: 9 additions & 0 deletions projects/packages/premium-analytics/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,13 @@
{
"extends": "jetpack-js-tools/tsconfig.base.json",
"compilerOptions": {
// Resolve cross-package imports between internal `packages/*` modules
// (`@jetpack-premium-analytics/<dir>`) to their TypeScript source for
// type-checking + IDE. The build resolves the same specifier separately (see
// README → "Internal packages"); this keeps tsc/esbuild and `tsgo` in sync.
Copy link
Copy Markdown
Contributor

@retrofox retrofox Jun 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems "Internal packages" doesn't exist.

"paths": {
"@jetpack-premium-analytics/*": [ "./packages/*/src" ]
Comment thread
manzoorwanijk marked this conversation as resolved.
}
},
"include": [ "routes/**/*", "packages/**/*" ]
}
Loading