Lint: use recommended components instead of deprecated Jetpack components by simison · Pull Request #49284 · Automattic/jetpack

simison · 2026-05-29T19:29:35Z

Follow-up to #48487

WIP

Disencourage usage of select Jetpack components & primitives and direct to use @wordpress/ui or @wordpress/components instead.

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Go to '..'

github-actions · 2026-05-29T19:30:40Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

…ents

simison · 2026-06-02T09:47:51Z

+	"subpaths": {
+		"button": "Use `Button` from `@wordpress/ui` instead.",
+		"global-notices": "Use `@wordpress/notices` instead.",
+		"gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",


Suggested change

"gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",

Allow.

simison · 2026-06-02T09:48:01Z

+		"button": "Use `Button` from `@wordpress/ui` instead.",
+		"global-notices": "Use `@wordpress/notices` instead.",
+		"gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",
+		"jetpack-footer": "Jetpack branding component — remove from denylist to allow.",


Suggested change

"jetpack-footer": "Jetpack branding component — remove from denylist to allow.",

Allow

simison · 2026-06-02T09:50:59Z

+		"H2": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",
+		"H3": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",


Would be good to map to a specific variants.

simison · 2026-06-02T09:51:22Z

+		"DiffViewer": "Jetpack-specific component — remove from denylist to allow.",
+		"DonutMeter": "Jetpack-specific visualization — remove from denylist to allow.",
+		"DotPager": "Jetpack-specific component — remove from denylist to allow.",
+		"getProductCheckoutUrl": "Jetpack utility — remove from denylist to allow.",


Suggested change

"getProductCheckoutUrl": "Jetpack utility — remove from denylist to allow.",

Remove utility.

simison · 2026-06-02T09:51:56Z

+		"getProductCheckoutUrl": "Jetpack utility — remove from denylist to allow.",
+		"GlobalNotices": "Use `@wordpress/notices` instead.",
+		"globalNoticesStore": "Use `@wordpress/notices` instead.",
+		"Gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",


Suggested change

"Gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",

Gravatar component is fine until we have something in UI and/or Gravatar package.

simison · 2026-06-02T09:52:24Z

+		"Gravatar": "Use `@gravatar-com/hovercards` or `@wordpress/components` when appropriate.",
+		"H2": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",
+		"H3": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",
+		"IconTooltip": "Use `Tooltip` from `@wordpress/ui` instead.",


Suggested change

"IconTooltip": "Use `Tooltip` from `@wordpress/ui` instead.",

"IconTooltip": "Use combination of `Icon` and `Tooltip` from `@wordpress/ui` instead.",

simison · 2026-06-02T09:53:23Z

+		"H3": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",
+		"IconTooltip": "Use `Tooltip` from `@wordpress/ui` instead.",
+		"IconsCard": "Jetpack-specific component — remove from denylist to allow.",
+		"IndeterminateProgressBar": "Use `Spinner` from `@wordpress/components` (no `@wordpress/ui` equivalent yet).",


Recommend Spinner and/or ProgressBar?

simison · 2026-06-02T09:53:39Z

+		"IconsCard": "Jetpack-specific component — remove from denylist to allow.",
+		"IndeterminateProgressBar": "Use `Spinner` from `@wordpress/components` (no `@wordpress/ui` equivalent yet).",
+		"isFirstMonthTrial": "Jetpack utility — remove from denylist to allow.",
+		"JetpackFooter": "Jetpack branding component — remove from denylist to allow.",


Suggested change

"JetpackFooter": "Jetpack branding component — remove from denylist to allow.",

Allow

simison · 2026-06-02T09:53:59Z

+		"JetpackProtectLogo": "Jetpack branding component — remove from denylist to allow.",
+		"JetpackSearchLogo": "Jetpack branding component — remove from denylist to allow.",
+		"JetpackVaultPressBackupLogo": "Jetpack branding component — remove from denylist to allow.",
+		"JetpackVideoPressLogo": "Jetpack branding component — remove from denylist to allow.",


Allow logos?

Suggested change

"JetpackProtectLogo": "Jetpack branding component — remove from denylist to allow.",

"JetpackSearchLogo": "Jetpack branding component — remove from denylist to allow.",

"JetpackVaultPressBackupLogo": "Jetpack branding component — remove from denylist to allow.",

"JetpackVideoPressLogo": "Jetpack branding component — remove from denylist to allow.",

simison · 2026-06-02T09:55:18Z

+		"JetpackSearchLogo": "Jetpack branding component — remove from denylist to allow.",
+		"JetpackVaultPressBackupLogo": "Jetpack branding component — remove from denylist to allow.",
+		"JetpackVideoPressLogo": "Jetpack branding component — remove from denylist to allow.",
+		"LoadingPlaceholder": "Use `Placeholder` from `@wordpress/components` (no `@wordpress/ui` equivalent yet).",


Incorrect, Placeholder has a different purpose.

Keep allowing or migrate to Spinner/ProgressBar for now?

simison · 2026-06-02T09:56:31Z

+		"ProductOffer": "Jetpack-specific pricing component — remove from denylist to allow.",
+		"ProductPrice": "Jetpack-specific pricing component — remove from denylist to allow.",
+		"ProgressBar": "Use `ProgressBar` from `@wordpress/components` (no `@wordpress/ui` equivalent yet).",
+		"QRCode": "Jetpack-specific component — remove from denylist to allow.",


Suggested change

"QRCode": "Jetpack-specific component — remove from denylist to allow.",

Used twice in the repo.

simison · 2026-06-02T09:57:24Z

+		"TermsOfService": "Jetpack-specific component — remove from denylist to allow.",
+		"Testimonials": "Jetpack-specific component — remove from denylist to allow.",
+		"Text": "Use `Text` from `@wordpress/ui` instead.",
+		"ThemeProvider": "Use `@wordpress/theme` instead.",


This might still continue provide Jetpack brand color but that said, it's a bit heavy-handed way to supply it.

simison · 2026-06-02T09:58:02Z

+		"Testimonials": "Jetpack-specific component — remove from denylist to allow.",
+		"Text": "Use `Text` from `@wordpress/ui` instead.",
+		"ThemeProvider": "Use `@wordpress/theme` instead.",
+		"Title": "Use `Text` from `@wordpress/ui` instead.",


Would be good to pin a specific variant.

simison · 2026-06-02T13:06:12Z

+		"Col": "Jetpack layout component — remove from denylist to allow or use `Stack` from `@wordpress/ui`.",
+		"Container": "Jetpack layout component — remove from denylist to allow or use `Stack` from `@wordpress/ui`.",


Via @keoshi:

Col and Container seem good to deprecate in favor of Stack . The instruction seems a bit conservative, but we should do it.

simison · 2026-06-02T13:09:32Z

+		"DetailsViewer": "Jetpack-specific component — remove from denylist to allow.",
+		"Dialog": "Use `Dialog` from `@wordpress/ui` instead.",
+		"DiffViewer": "Jetpack-specific component — remove from denylist to allow.",
+		"DonutMeter": "Jetpack-specific visualization — remove from denylist to allow.",


@keoshi noted:

DonutMeter not related to wp-ui, but we are consolidating all data viz pieces in the chart library; e.g.: https://automattic.github.io/jetpack-storybook/?path=/docs/js-packages-charts-library-charts-pie-chart--docs

Suggested change

"DonutMeter": "Jetpack-specific visualization — remove from denylist to allow.",

"DonutMeter": "Use `PieChart` from `@automattic/charts` instead.",

See package

github-actions Bot added [Status] In Progress Docs labels May 29, 2026

github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label May 29, 2026

simison mentioned this pull request Jun 1, 2026

Eslint: fix ignored files #49310

Merged

simison and others added 2 commits June 2, 2026 12:34

Eslint: create eslint rule to disencourage using deprecated JP compon…

88031e5

…ents

Update jetpack-components-denylist.json

846e88f

simison commented Jun 2, 2026

View reviewed changes

simison force-pushed the update/use-recommended-components-jetpack-comps branch from 9da7b22 to 846e88f Compare June 2, 2026 09:48

simison commented Jun 2, 2026

View reviewed changes

simison added 2 commits June 2, 2026 13:05

Update eslint-excludelist.json

df916df

Unwind setup and use existing

b960781

simison requested a review from keoshi June 2, 2026 10:17

simison added 2 commits June 2, 2026 13:21

Update globals.node config

9fd747f

Remove json instructions from file, rely on readme

770e765

simison commented Jun 2, 2026

View reviewed changes

		"H2": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",
		"H3": "Use `Text` with `variant=\"heading-*\"` from `@wordpress/ui` instead.",

	"IconTooltip": "Use `Tooltip` from `@wordpress/ui` instead.",
	"IconTooltip": "Use combination of `Icon` and `Tooltip` from `@wordpress/ui` instead.",

		"Col": "Jetpack layout component — remove from denylist to allow or use `Stack` from `@wordpress/ui`.",
		"Container": "Jetpack layout component — remove from denylist to allow or use `Stack` from `@wordpress/ui`.",

	"DonutMeter": "Jetpack-specific visualization — remove from denylist to allow.",
	"DonutMeter": "Use `PieChart` from `@automattic/charts` instead.",

Conversation

simison commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

Uh oh!

github-actions Bot commented May 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simison Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

simison Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

simison commented May 29, 2026 •

edited

Loading

github-actions Bot commented May 29, 2026 •

edited

Loading

simison Jun 2, 2026 •

edited

Loading

simison Jun 2, 2026 •

edited

Loading