Skip to content

VideoPress: restructure upgrade notice as Title + Description + ActionButton #49400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CGastrell merged 3 commits into from
Jun 5, 2026
+19 −15
Merged

VideoPress: restructure upgrade notice as Title + Description + ActionButton #49400

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
432a8c1
VideoPress: replace black Notice.ActionButton upgrade CTA with primar…
CGastrell Jun 4, 2026
6dce0f9
Render VideoPress upgrade CTA as Notice.ActionLink instead of a fille…
CGastrell Jun 4, 2026
d50fd1c
VideoPress: restructure upgrade notice as Title + Description + Actio…
CGastrell Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/packages/videopress/changelog/fix-videopress-upgrade-cta-black-button
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: fixed

Restructure the free-plan upgrade notice into a balanced Notice.Title heads-up line, a Notice.Description upsell pitch, and a concise "Upgrade" Notice.ActionButton, replacing the out-of-place dark button.
30 changes: 15 additions & 15 deletions projects/packages/videopress/src/client/admin/components/admin-page/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,10 @@ const UPGRADE_TRIGGER_FREE_PLAN_TEXT = __(
'The free plan includes one video upload.',
'jetpack-videopress-pkg'
);
const UPGRADE_TRIGGER_UNLOCK_TEXT = __(
'Unlock unlimited videos, 1TB of storage, and more!',
'jetpack-videopress-pkg'
);

const UpgradeTrigger = ( { hasUsedVideo = false }: { hasUsedVideo: boolean } ) => {
const { adminUri, siteSuffix } = window.jetpackVideoPressInitialState;
Expand Down Expand Up @@ -252,24 +256,20 @@ const UpgradeTrigger = ( { hasUsedVideo = false }: { hasUsedVideo: boolean } ) =
// VIDP-245: keep the `Notice.Root` children shape invariant across the
// `hasUsedVideo` flip. base-ui@1.4.1's `useRenderElement` swaps between two
// different ref-merge hooks depending on subtree shape, so conditionally
// mounting `<Notice.Description>` (as this did before) misaligns its stored
// fork-ref and crashes on the next upload/delete. Always render the
// Description — mirroring the modern dashboard's `free-tier-notice.tsx` —
// varying only its text, with a non-empty fallback nudge before the first
// upload so we never render an empty styled row. The two strings are hoisted
// to module scope (above) to avoid the terser i18n ternary-fold.
const description = hasUsedVideo
? UPGRADE_TRIGGER_USED_VIDEO_TEXT
: UPGRADE_TRIGGER_FREE_PLAN_TEXT;

const cta = __(
'Upgrade now to unlock unlimited videos, 1TB of storage, and more!',
'jetpack-videopress-pkg'
);
// mounting/unmounting a `Notice` subcomponent across the flip misaligns its
// stored fork-ref and crashes on the next upload/delete. Therefore always
// render `Notice.Title`, `Notice.Description` and `Notice.Actions` — never
// wrap any of them in a `hasUsedVideo && (...)` conditional. Vary only the
// TEXT: the `title` line carries the contextual heads-up (non-empty in both
// states) while the Description holds the constant upsell pitch. The strings
// are hoisted to module scope (above) to avoid the terser i18n ternary-fold.
const title = hasUsedVideo ? UPGRADE_TRIGGER_USED_VIDEO_TEXT : UPGRADE_TRIGGER_FREE_PLAN_TEXT;
const cta = __( 'Upgrade', 'jetpack-videopress-pkg' );

return (
<Notice.Root intent="info" className={ styles[ 'upgrade-trigger' ] }>
<Notice.Description>{ description }</Notice.Description>
<Notice.Title>{ title }</Notice.Title>
<Notice.Description>{ UPGRADE_TRIGGER_UNLOCK_TEXT }</Notice.Description>
<Notice.Actions>
<Notice.ActionButton onClick={ onButtonClickHandler }>{ cta }</Notice.ActionButton>
</Notice.Actions>
Expand Down
Loading