Fix live setup WebKit predicate#679
Open
brandonpayton wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
settleAfterKernelDestroyso the WebKit browser predicate is a callable helper instead of a boolean value being invoked as a function.applyBootDescriptorTypeError that prevented ABI 14 images from booting.Validation
git diff --checknpm run buildinapps/browser-demosnpx playwright test test/kandelo-webkit-smoke.spec.ts --project=webkit --grep "boots and accepts terminal input"http://127.0.0.1:5402/?demo=shell, with page errors andapplyBootDescriptor/TypeErrorconsole errors captured