fix for broken websites when hosted into sub-directory and other path related issues#68
Open
erikyo wants to merge 15 commits into
Open
fix for broken websites when hosted into sub-directory and other path related issues#68erikyo wants to merge 15 commits into
erikyo wants to merge 15 commits into
Conversation
…s installed into a subdirectory... but since it has been a long time and the pr is behind I'll make a new one
…d and siteurl returns also the name of the subdomain. It would be better to create in dependency-path-mapping a base path, but for the moment this fixes the issue
…atic fs paths. maybe it could be avoided but without this I miss the block style
erikyo
changed the title
erikyo
changed the title
since the backend section is also the broken, this solves temporarily. the issue was related to uri_path_to_fs_path() when serving files from /wp-admin and /wp-includes (eg. src="/wp-admin/css/blocks.css") because with is_descendant_uri we check if it starts with the name of the subfolder ($this->site_dir)
…emove the old fix)
erikyo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the PR #47 was old and the code need to be updated, I have created a new PR to fix this problem that need less fixes, probably because in time this issue has been almost solved except for few things.
in addition, I've noticed that there were a bunch of issues open since a long time, it's a pity because this plugin is well written and goes pretty fast.
In particular I (hope to) have closed:
I tested the plugin in a "normal" site (hosted in the root folder) and it works after these changes.