Fix mutation of $obj->src with style_loader_src filter#95
Draft
mreishus wants to merge 5 commits into
Draft
Conversation
The previous implementation grouped all concatenatable CSS files into a single bundle that was always output first, before non-concatenatable items. This broke the relative order between concatenated stylesheets and non-concatenated items (such as files with inline styles). This caused issues where theme stylesheets that should appear after Gutenberg's global styles were instead output before them, allowing Gutenberg's `a:where(:not(.wp-element-button))` rule to override theme link styling due to CSS cascade order. The fix adopts the same approach used in concat-js.php: use a level counter where non-concatenatable items break the current concat group (double-increment pattern), preserving the original WordPress enqueue order. Fixes DOTTHEM-159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.