Skip to content

Migrate general settings events to Event Horizon#5101

Open
MiSikora wants to merge 1 commit intomehow/task/event-horizon-settings-2from
mehow/task/event-horizon-settings-3
Open

Migrate general settings events to Event Horizon#5101
MiSikora wants to merge 1 commit intomehow/task/event-horizon-settings-2from
mehow/task/event-horizon-settings-3

Conversation

@MiSikora
Copy link
Contributor

Description

This migrates settings related events to Event Horizon.

Relates to PCDROID-419

Testing Instructions

I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.

  • settings_general_shown
  • settings_general_row_action_changed
  • settings_general_episode_grouping_changed
  • settings_general_episode_grouping_apply_to_existing
  • settings_general_episode_grouping_do_not_apply_to_existing
  • settings_general_archived_episodes_changed
  • settings_general_archived_episodes_apply_to_existing
  • settings_general_archived_episodes_do_not_apply_to_existing
  • settings_general_up_next_swipe_changed
  • settings_general_skip_forward_changed
  • settings_general_skip_back_changed
  • settings_general_keep_screen_awake_toggled
  • settings_general_open_player_automatically_toggled
  • settings_general_intelligent_playback_toggled
  • settings_general_play_up_next_on_tap_toggled
  • settings_general_shake_to_reset_sleep_timer_toggled
  • settings_general_auto_sleep_timer_restart_toggled
  • settings_general_media_notification_controls_shown
  • settings_general_media_notification_controls_show_custom_toggled
  • settings_general_media_notification_next_previous_track_skip_buttons_toggled
  • settings_general_media_notification_controls_order_changed
  • settings_general_autoplay_toggled
  • settings_use_real_time_for_playback_remaining_time

Screenshots or Screencast

N/A

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 8.8 milestone Mar 10, 2026
@MiSikora MiSikora requested a review from a team as a code owner March 10, 2026 10:42
@MiSikora MiSikora removed the request for review from a team March 10, 2026 10:42
@MiSikora MiSikora added the [Area] Analytics Analytics related issues label Mar 10, 2026
@MiSikora MiSikora requested a review from sztomek March 10, 2026 10:42
@MiSikora MiSikora added do not merge [Type] Enhancement Improve an existing feature. labels Mar 10, 2026
Copilot AI review requested due to automatic review settings March 10, 2026 10:42
@dangermattic
Copy link
Collaborator

1 Error
🚫 This PR is tagged with do not merge label(s).

Generated by 🚫 Danger

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates a set of settings-related analytics events from the legacy AnalyticsTracker/AnalyticsEvent pipeline to Event Horizon, aligning settings screens with the newer tracking infrastructure (PCDROID-419).

Changes:

  • Replaced AnalyticsTracker.track(...) calls with EventHorizon.track(...) across playback and media notification settings UI.
  • Added Event Horizon enum/value mappings to settings models (e.g., UpNextActionUpNextSwipeActionType).
  • Bumped the eventhorizon dependency version to include the needed event definitions/types.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
modules/services/preferences/src/main/java/au/com/shiftyjelly/pocketcasts/preferences/Settings.kt Adds Event Horizon mapping value to UpNextAction for consistent typed tracking.
modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notification/MediaActionsViewModel.kt Switches media notification controls tracking to Event Horizon events.
modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notification/MediaActionsFragment.kt Tracks the media notification controls screen “shown” event via Event Horizon.
modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/PlaybackSettingsFragment.kt Migrates multiple general/playback settings events to Event Horizon with typed payloads.
gradle/libs.versions.toml Updates the Event Horizon library version to a newer Pocket Casts build.

@wpmobilebot
Copy link
Collaborator

Project dependencies changes

list
! Upgraded Dependencies
com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef, (changed from pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d)
tree
 +--- project :modules:features:account
 |    \--- project :modules:features:search
 |         \--- project :modules:services:analytics
-|              +--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d
+|              +--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef
 |              \--- project :modules:services:model
-|                   +--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+|                   +--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*)
 |                   \--- project :modules:services:utils
 |                        \--- project :modules:services:payment
-|                             \--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+|                             \--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*)
 \--- project :modules:features:discover
      \--- project :modules:features:podcasts
           \--- project :modules:features:player
                \--- project :modules:features:transcripts
                     \--- project :modules:services:sharing
-                         \--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+                         \--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*)

@MiSikora MiSikora force-pushed the mehow/task/event-horizon-settings-3 branch from 827dec3 to 2401614 Compare March 10, 2026 11:07
@MiSikora MiSikora changed the title Migrate settings events to Event Horizon Migrate general settings events to Event Horizon Mar 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Analytics Analytics related issues do not merge [Type] Enhancement Improve an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants