Migrate general settings events to Event Horizon#5101
Open
MiSikora wants to merge 1 commit intomehow/task/event-horizon-settings-2from
Open
Migrate general settings events to Event Horizon#5101MiSikora wants to merge 1 commit intomehow/task/event-horizon-settings-2from
MiSikora wants to merge 1 commit intomehow/task/event-horizon-settings-2from
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates a set of settings-related analytics events from the legacy AnalyticsTracker/AnalyticsEvent pipeline to Event Horizon, aligning settings screens with the newer tracking infrastructure (PCDROID-419).
Changes:
- Replaced
AnalyticsTracker.track(...)calls withEventHorizon.track(...)across playback and media notification settings UI. - Added Event Horizon enum/value mappings to settings models (e.g.,
UpNextAction→UpNextSwipeActionType). - Bumped the
eventhorizondependency version to include the needed event definitions/types.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| modules/services/preferences/src/main/java/au/com/shiftyjelly/pocketcasts/preferences/Settings.kt | Adds Event Horizon mapping value to UpNextAction for consistent typed tracking. |
| modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notification/MediaActionsViewModel.kt | Switches media notification controls tracking to Event Horizon events. |
| modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/notification/MediaActionsFragment.kt | Tracks the media notification controls screen “shown” event via Event Horizon. |
| modules/features/settings/src/main/java/au/com/shiftyjelly/pocketcasts/settings/PlaybackSettingsFragment.kt | Migrates multiple general/playback settings events to Event Horizon with typed payloads. |
| gradle/libs.versions.toml | Updates the Event Horizon library version to a newer Pocket Casts build. |
.../src/main/java/au/com/shiftyjelly/pocketcasts/settings/notification/MediaActionsViewModel.kt
Show resolved
Hide resolved
Collaborator
Project dependencies changeslist! Upgraded Dependencies
com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef, (changed from pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d)tree +--- project :modules:features:account
| \--- project :modules:features:search
| \--- project :modules:services:analytics
-| +--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d
+| +--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef
| \--- project :modules:services:model
-| +--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+| +--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*)
| \--- project :modules:services:utils
| \--- project :modules:services:payment
-| \--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+| \--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*)
\--- project :modules:features:discover
\--- project :modules:features:podcasts
\--- project :modules:features:player
\--- project :modules:features:transcripts
\--- project :modules:services:sharing
- \--- com.automattic:eventhorizon:pocket-casts-47320387f3fcd90c3d145cc76c2765c98483194d (*)
+ \--- com.automattic:eventhorizon:pocket-casts-d29c439f463f93c9b1b0d5d642a2cc746e37dcef (*) |
827dec3 to
2401614
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates settings related events to Event Horizon.
Relates to PCDROID-419
Testing Instructions
I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.
settings_general_shownsettings_general_row_action_changedsettings_general_episode_grouping_changedsettings_general_episode_grouping_apply_to_existingsettings_general_episode_grouping_do_not_apply_to_existingsettings_general_archived_episodes_changedsettings_general_archived_episodes_apply_to_existingsettings_general_archived_episodes_do_not_apply_to_existingsettings_general_up_next_swipe_changedsettings_general_skip_forward_changedsettings_general_skip_back_changedsettings_general_keep_screen_awake_toggledsettings_general_open_player_automatically_toggledsettings_general_intelligent_playback_toggledsettings_general_play_up_next_on_tap_toggledsettings_general_shake_to_reset_sleep_timer_toggledsettings_general_auto_sleep_timer_restart_toggledsettings_general_media_notification_controls_shownsettings_general_media_notification_controls_show_custom_toggledsettings_general_media_notification_next_previous_track_skip_buttons_toggledsettings_general_media_notification_controls_order_changedsettings_general_autoplay_toggledsettings_use_real_time_for_playback_remaining_timeScreenshots or Screencast
N/A
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...