Migrate wear events to Event Horizon#5109
Open
MiSikora wants to merge 1 commit intomehow/task/event-horizon-miscfrom
Open
Migrate wear events to Event Horizon#5109MiSikora wants to merge 1 commit intomehow/task/event-horizon-miscfrom
MiSikora wants to merge 1 commit intomehow/task/event-horizon-miscfrom
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates Wear OS analytics from the legacy AnalyticsTracker/AnalyticsEvent system to Event Horizon, aligning wear tracking with the newer analytics pipeline (PCDROID-419).
Changes:
- Replace
AnalyticsTracker.track(AnalyticsEvent.*)calls withEventHorizon.track(*Event)in Wear view models. - Update Wear unit tests to assert tracked Event Horizon events via
TestEventSink. - Add the analytics testing module as a Wear test dependency.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| wear/src/test/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/WatchListScreenViewModelTest.kt | Switches analytics assertions to Event Horizon events using TestEventSink. |
| wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/RequirePlusViewModel.kt | Migrates “require plus shown” tracking to Event Horizon. |
| wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/authentication/LoginViewModel.kt | Migrates Wear sign-in shown/tapped events to Event Horizon. |
| wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/WatchListScreenViewModel.kt | Migrates main list shown/tapped events to Event Horizon. |
| wear/build.gradle.kts | Adds modules.services.analytics.testing for Wear unit tests. |
wear/src/main/kotlin/au/com/shiftyjelly/pocketcasts/wear/ui/WatchListScreenViewModel.kt
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates Wear OS related events to Event Horizon.
Relates to PCDROID-419
Testing Instructions
I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.
wear_main_list_shownwear_main_list_now_playing_tappedwear_main_list_podcasts_tappedwear_main_list_downloads_tappedwear_main_list_filters_tappedwear_main_list_files_tappedwear_main_list_starred_tappedwear_main_list_settings_tappedwear_require_plus_shownwear_signin_shownwear_signin_google_tappedwear_signin_phone_tappedwear_signin_email_tappedScreenshots or Screencast
N/A
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...