Skip to content

Migrate transcripts events to Event Horizon#5111

Open
MiSikora wants to merge 1 commit intomehow/task/event-horizon-chaptersfrom
mehow/task/event-horizon-transcripts
Open

Migrate transcripts events to Event Horizon#5111
MiSikora wants to merge 1 commit intomehow/task/event-horizon-chaptersfrom
mehow/task/event-horizon-transcripts

Conversation

@MiSikora
Copy link
Contributor

Description

This migrates transcripts events to Event Horizon.

Relates to PCDROID-419

Testing Instructions

I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.

  • transcript_shown
  • transcript_dismissed
  • transcript_error
  • transcript_search_shown
  • transcript_search_next_result
  • transcript_search_previous_result
  • transcript_generated_paywall_shown
  • transcript_generated_paywall_dismissed
  • transcript_generated_paywall_subscribe_tapped

Screenshots or Screencast

N/A

Checklist

  • If this is a user-facing change, I have added an entry in CHANGELOG.md
  • Ensure the linter passes (./gradlew spotlessApply to automatically apply formatting/linting)
  • I have considered whether it makes sense to add tests for my changes
  • All strings that need to be localized are in modules/services/localization/src/main/res/values/strings.xml
  • Any jetpack compose components I added or changed are covered by compose previews
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

I have tested any UI changes...

  • with different themes
  • with a landscape orientation
  • with the device set to have a large display and font size
  • for accessibility with TalkBack

@MiSikora MiSikora added this to the 8.8 milestone Mar 11, 2026
@MiSikora MiSikora added the [Area] Analytics Analytics related issues label Mar 11, 2026
@MiSikora MiSikora requested a review from a team as a code owner March 11, 2026 12:44
Copilot AI review requested due to automatic review settings March 11, 2026 12:44
@MiSikora MiSikora added the [Type] Enhancement Improve an existing feature. label Mar 11, 2026
@MiSikora MiSikora requested review from geekygecko and removed request for a team March 11, 2026 12:44
@dangermattic
Copy link
Collaborator

1 Error
🚫 This PR is tagged with do not merge label(s).

Generated by 🚫 Danger

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Migrates transcript-related analytics from the legacy AnalyticsTracker/AnalyticsEvent system to Event Horizon, ensuring transcript UI interactions emit strongly-typed Event Horizon events across the transcripts feature and player.

Changes:

  • Replaced transcript event tracking in TranscriptViewModel (error + search events) with Event Horizon events.
  • Updated transcript UI entry points (episode transcript dialog + player transcript page) to emit Event Horizon events for transcript shown/dismissed and generated-transcript paywall interactions.
  • Updated transcript type mapping to use Event Horizon’s TranscriptType enum and adjusted unit tests to construct the ViewModel without AnalyticsTracker.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/to/TranscriptType.kt Replaces string analytics values with Event Horizon TranscriptType mapping for transcript events.
modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptViewModel.kt Removes AnalyticsTracker plumbing; tracks transcript error/search events via Event Horizon.
modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptFragment.kt Migrates transcript shown + generated-paywall events in the episode transcript dialog to Event Horizon.
modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/PlayerHeaderFragment.kt Migrates transcript shown/dismissed + generated-paywall events in the player transcript surface to Event Horizon.
modules/features/transcripts/src/test/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptViewModelTest.kt Updates test setup for the ViewModel constructor changes (Event Horizon sink, no AnalyticsTracker).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Area] Analytics Analytics related issues do not merge [Type] Enhancement Improve an existing feature.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants