Migrate transcripts events to Event Horizon#5111
Open
MiSikora wants to merge 1 commit intomehow/task/event-horizon-chaptersfrom
Open
Migrate transcripts events to Event Horizon#5111MiSikora wants to merge 1 commit intomehow/task/event-horizon-chaptersfrom
MiSikora wants to merge 1 commit intomehow/task/event-horizon-chaptersfrom
Conversation
Collaborator
Generated by 🚫 Danger |
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates transcript-related analytics from the legacy AnalyticsTracker/AnalyticsEvent system to Event Horizon, ensuring transcript UI interactions emit strongly-typed Event Horizon events across the transcripts feature and player.
Changes:
- Replaced transcript event tracking in
TranscriptViewModel(error + search events) with Event Horizon events. - Updated transcript UI entry points (episode transcript dialog + player transcript page) to emit Event Horizon events for transcript shown/dismissed and generated-transcript paywall interactions.
- Updated transcript type mapping to use Event Horizon’s
TranscriptTypeenum and adjusted unit tests to construct the ViewModel withoutAnalyticsTracker.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| modules/services/model/src/main/java/au/com/shiftyjelly/pocketcasts/models/to/TranscriptType.kt | Replaces string analytics values with Event Horizon TranscriptType mapping for transcript events. |
| modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptViewModel.kt | Removes AnalyticsTracker plumbing; tracks transcript error/search events via Event Horizon. |
| modules/features/transcripts/src/main/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptFragment.kt | Migrates transcript shown + generated-paywall events in the episode transcript dialog to Event Horizon. |
| modules/features/player/src/main/java/au/com/shiftyjelly/pocketcasts/player/view/PlayerHeaderFragment.kt | Migrates transcript shown/dismissed + generated-paywall events in the player transcript surface to Event Horizon. |
| modules/features/transcripts/src/test/kotlin/au/com/shiftyjelly/pocketcasts/transcripts/TranscriptViewModelTest.kt | Updates test setup for the ViewModel constructor changes (Event Horizon sink, no AnalyticsTracker). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This migrates transcripts events to Event Horizon.
Relates to PCDROID-419
Testing Instructions
I would mostly focus on the code review and smoke test some of these events as the migration process is rather a mechanical one.
transcript_showntranscript_dismissedtranscript_errortranscript_search_showntranscript_search_next_resulttranscript_search_previous_resulttranscript_generated_paywall_showntranscript_generated_paywall_dismissedtranscript_generated_paywall_subscribe_tappedScreenshots or Screencast
N/A
Checklist
./gradlew spotlessApplyto automatically apply formatting/linting)modules/services/localization/src/main/res/values/strings.xmlI have tested any UI changes...