Unlock all styles now that Sustainer is discontinued by joashrajin · Pull Request #1847 · Automattic/simplenote-android

joashrajin · 2026-07-09T21:28:57Z

Fix

Simplenote Sustainer has been discontinued, and pref_key_premium is never written anywhere in the codebase's history, so isPremium() was always false — leaving every style except Default permanently locked and the Style row hidden in Settings, even though a pure-black AMOLED style (Black) already exists.

Per review feedback, this is the minimal change:

PrefUtils.isPremium now defaults to true (no device ever stored a value, so this unlocks everyone).
The pref_key_style row in preferences.xml is visible again (app:isPreferenceVisible="true").

Fixes #1771
Fixes #1661

Test

Go to Settings — the Style row is visible under Appearance.
Open it and verify no styles show a lock icon and each can be selected.
Select Black and enable dark mode — backgrounds are pure black (AMOLED).
Add the note widget and note list widget in dark mode with the Black style selected — widgets use the black layouts.

Review

Anyone can review. Note: with isPremium() defaulting to true, the (still hidden) membership row would show "premium" if ever un-hidden.

Release

RELEASE-NOTES.txt was updated in 6e28103 with:

Unlocked all styles, including the pure-black AMOLED style, for everyone now that Simplenote Sustainer is discontinued

dangermattic · 2026-07-09T21:29:23Z

	1 Warning
⚠️	PR is not assigned to a milestone.

Generated by 🚫 Danger

wpmobilebot · 2026-07-09T21:32:48Z

📲 You can test the changes from this Pull Request in Simplenote Android by scanning the QR code below to install the corresponding build.

	App Name	Simplenote Android
	Build Type	Debug
	Commit	`6e28103`
	Direct Download	`simplenote-android-prototype-build-pr1847-6e28103-019f60f9-2c3a-40b8-acc8-2014a9ca5f31.apk`

joashrajin · 2026-07-09T21:36:29Z

@mzorz thoughts on this? since sustainer is done away with, maybe we release this to all?

Copilot

Pull request overview

Removes the now-defunct “premium” gating from style selection so all users can choose and apply any available style (including the Black/AMOLED style) across the app UI and widgets.

Changes:

Always apply the user-selected style in ThemeUtils.getStyle() and widget/layout selectors (no fallback to Default for non-premium).
Simplify StyleActivity UX by removing lock indicators and the locked/upsell dialog so tapping a style always selects it.
Update Settings’ style summary to always reflect the selected style name, and add release notes entry for the change.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
Simplenote/src/main/java/com/automattic/simplenote/utils/ThemeUtils.java	Always returns the selected style (removes premium gate).
Simplenote/src/main/java/com/automattic/simplenote/utils/PrefUtils.java	Removes premium-based fallbacks for widget layouts and dialog theme selection; removes unused default style name helper.
Simplenote/src/main/java/com/automattic/simplenote/StyleActivity.java	Removes premium lock UI/upsell dialog; enables selecting any style.
Simplenote/src/main/java/com/automattic/simplenote/PreferencesFragment.java	Settings summary always shows the currently selected style.
RELEASE-NOTES.txt	Documents unlocking styles for all users.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

joashrajin · 2026-07-09T21:39:18Z

        public StyleAdapter(List<String> styles) {
            this.mStyles = new ArrayList<>(styles);
-            mSelectedPosition = mIsPremium ? PrefUtils.getStyleIndexSelected(StyleActivity.this) : STYLE_DEFAULT;
+            mSelectedPosition = PrefUtils.getStyleIndexSelected(StyleActivity.this);
        }


Addressed in 12d22e5.

joashrajin · 2026-07-09T21:39:19Z

+                        notifyItemChanged(mSelectedPosition);
+                        mSelectedPosition = holder.getAdapterPosition();
+                        notifyItemChanged(mSelectedPosition);
+                        PrefUtils.setStyleIndex(StyleActivity.this, holder.getAdapterPosition());


Addressed in 12d22e5.

theck13 · 2026-07-09T23:47:52Z

You don't need all these changes to enable styles. Just update PrefUtils.isPremium and preferences.pref_key_style from false to true.

joashrajin · 2026-07-14T14:02:54Z

You don't need all these changes to enable styles. Just update PrefUtils.isPremium and preferences.pref_key_style from false to true.

Thank you. will do

Per review feedback, the minimal change: default PrefUtils.isPremium to true (pref_key_premium was never written anywhere, so no device has a stored value) and make the Style preference row visible in Settings. Fixes #1771 Fixes #1661

joashrajin · 2026-07-14T14:13:06Z

Thanks @theck13, I reworked to exactly that in 6e28103: isPremium() now defaults to true and the pref_key_style row is visible again. I confirmed pref_key_premium was never written anywhere in the repo's history, so no device has a stored false to override the new default.

joashrajin requested a review from Copilot July 9, 2026 21:36

joashrajin self-assigned this Jul 9, 2026

Copilot started reviewing on behalf of joashrajin July 9, 2026 21:36 View session

Copilot AI reviewed Jul 9, 2026

View reviewed changes

joashrajin force-pushed the remove/style-premium-gate branch from 12d22e5 to 6e28103 Compare July 14, 2026 14:12

joashrajin marked this pull request as ready for review July 14, 2026 14:35

joashrajin added [Type] Enhancement Improve existing functionality. [status] needs code review labels Jul 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Unlock all styles now that Sustainer is discontinued - #1847

Unlock all styles now that Sustainer is discontinued#1847
joashrajin wants to merge 1 commit into
trunkfrom
remove/style-premium-gate

joashrajin commented Jul 9, 2026 •

edited

Loading

Uh oh!

dangermattic commented Jul 9, 2026 •

edited

Loading

Uh oh!

wpmobilebot commented Jul 9, 2026 •

edited

Loading

Uh oh!

joashrajin commented Jul 9, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

joashrajin Jul 9, 2026

Uh oh!

joashrajin Jul 9, 2026

Uh oh!

theck13 commented Jul 9, 2026

Uh oh!

joashrajin commented Jul 14, 2026

Uh oh!

joashrajin commented Jul 14, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

joashrajin commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Fix

Test

Review

Release

Uh oh!

dangermattic commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented Jul 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

joashrajin commented Jul 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

joashrajin Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

joashrajin Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

theck13 commented Jul 9, 2026

Uh oh!

joashrajin commented Jul 14, 2026

Uh oh!

joashrajin commented Jul 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

joashrajin commented Jul 9, 2026 •

edited

Loading

dangermattic commented Jul 9, 2026 •

edited

Loading

wpmobilebot commented Jul 9, 2026 •

edited

Loading

joashrajin commented Jul 14, 2026 •

edited

Loading