Bump blueprints.phar to v0.8.1 (fix git:directory ref HEAD)#3631
Open
ivan-ottinger wants to merge 1 commit into
Open
Bump blueprints.phar to v0.8.1 (fix git:directory ref HEAD)#3631ivan-ottinger wants to merge 1 commit into
ivan-ottinger wants to merge 1 commit into
Conversation
The previously bundled PHAR built `refs/heads/HEAD` as a literal branch name when callers passed `ref: "HEAD"`, breaking gallery blueprints like Commerce on the native PHP runtime. v0.8.1 contains the upstream fix (WordPress/php-toolkit#294) to GitRemote::fetch, which now resolves HEAD as the symref it is.
Contributor
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
📊 Performance Test ResultsComparing 1bf1045 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
|
Thanks for looking into this, @ivan-ottinger 👍 However, the static blueprints.phar also contains WordPress/php-toolkit#280 and WordPress/php-toolkit#281. We need both of those patches, too. So until they're merged, we'll need to rebuild a static blueprints.phar against the latest version, with both of those patches applied, too |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
HEAD, ...) fails withBranch "refs/heads/HEAD" not foundWordPress/php-toolkit#292Proposed Changes
wp-files/blueprints/blueprints.pharwith the v0.8.1 release asset fromWordPress/php-toolkit.ff7f5657961f8b9a604f7131c4eac5c2673a3f7665a304268e2287d24c0c7a0f(2,294,271 bytes)05503c954e4c3caea0da8e7d9c28bb5e5470e8121c41e4713c262e2cf4af0d16(1,781,056 bytes)The previously bundled PHAR built
refs/heads/HEADas a literal branch name when callers passedref: "HEAD", so any Blueprint usinggit:directorywithref: "HEAD"failed on the native PHP runtime withGitRemoteException: Branch "refs/heads/HEAD" not found on remote origin. v0.8.1 ships the upstream fix.This PR is intentionally scoped to the PHAR bump — auto-install (removed in #3491) is intentionally not touched here.
Testing Instructions
npm install(no source changes; the PHAR is the only file that moves).Failed to start WordPress server: PHP command failederror and thatwp-content/plugins/wc-smooth-generator/is present in the new site.Pre-merge Checklist