This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Block themes: Update templates to include a Query block wrapper#3821
Merged
Conversation
Contributor
|
Sadly this breaks the alignments for the query pagination block on Quadrat, I'm trying to confirm if it's a bug or not, will come back to this when I find out. |
MaggieCabrera
force-pushed
the
update/block-themes-query-wrapper
branch
from
783d283 to
cee559d
Compare
Contributor
|
So this PR is fine but needs WordPress/gutenberg#31833 in order to land since it would break Quadrat's query pagination alignment otherwise. Once that's merged, it's good to go. |
MaggieCabrera
approved these changes
May 20, 2021
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
This is ok to merge now!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WordPress/gutenberg#30804
I was able to observe the Alignment control for the Query block on the BCB Search template but not on the Index - not sure, what that is about.