Canard: Fix editor block styles#4797
Conversation
| */ | ||
| function canard_editor_styles() { | ||
| wp_enqueue_style( 'canard-editor-block-style', get_template_directory_uri() . '/editor-blocks.css' ); | ||
| wp_enqueue_style( 'canard-block-style', get_template_directory_uri() . '/blocks.css' ); |
There was a problem hiding this comment.
I think its probably better to enqueue this before the editor styles so that if they ever target the same selectors the editor styles win.
There was a problem hiding this comment.
Thanks for 👀 - changed!
|
This works for me on the editor, but not on the front end. |
|
@scruffian Would you mind sharing a bit more info on how you are testing? It seems to be working fine for me:
|
|
I've tried testing locally and on wordpress.com: |
|
I think this needs a Gutenberg fix: WordPress/gutenberg#35514 |
|
In my testing, this is no longer needed when running GB trunk |
|
I can't verify that it works correctly, as I can't get Canard to display the Text Color setting: |
|
I believe that the setting has moved underneath Highlight - there's a text color option there... |
I was wondering that. Thank you for clarifying. So just to double-check, you're saying that with the latest Gutenberg trunk the Highlight Text color works correctly both in the editor and the page? |
|
Yeah, it does for me. |
|
@danieldudzic does it work for you? |
|
I am running the latest version of Gutenberg trunk (re-compiled) and the latest version of Canard locally and I get:
|
|
Sorry, you're right in the editor, this PR is needed as well. |
2 participants
Closes #4761