This repository was archived by the owner on Feb 17, 2025. It is now read-only.
Fixed null-ref error when previewing colors for any theme but Skatepark#5014
Merged
Conversation
This was referenced Nov 10, 2021
MaggieCabrera
approved these changes
Nov 11, 2021
Contributor
MaggieCabrera
left a comment
MaggieCabrera
left a comment
There was a problem hiding this comment.
thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR enabling Duotone customizations via the customizer seems to have introduced a null-ref error. It's checking for the existence of a global variable so I thought the original code was fine but Chrome was throwing an error and made color customization previews stop working.
To reproduce try to change the colors in Blockbase. Note the console error.
This change fixes that by referencing
window.where the variable actually resides.