Skip to content
This repository was archived by the owner on Feb 17, 2025. It is now read-only.

Update Navigation Alignment for popular themes#7577

Closed
scruffian wants to merge 8 commits into
trunkfrom
update/navigation-alignment-2
Closed

Update Navigation Alignment for popular themes#7577
scruffian wants to merge 8 commits into
trunkfrom
update/navigation-alignment-2

Conversation

@scruffian
Copy link
Copy Markdown
Member

@scruffian scruffian commented Dec 21, 2023

Changes proposed in this Pull Request:

The following themes have right aligned navigation in their overlay which is probably not the intended design. This PR switches them to be left aligned.

  • Foam
  • Adventurer
  • Lativ
  • Bibimbap
  • Startfit
  • Erma
  • Jaida

Screenshots

Before
Screenshot 2023-12-21 at 13 45 04
After
Screenshot 2023-12-21 at 13 45 17
Before
Screenshot 2023-12-21 at 13 43 27
After
Screenshot 2023-12-21 at 13 43 38
Before
Screenshot 2023-12-21 at 13 47 59
After
Screenshot 2023-12-21 at 13 37 43
Before
Screenshot 2023-12-21 at 13 35 06
After
Screenshot 2023-12-21 at 13 34 55
Before
Screenshot 2023-12-21 at 13 29 39
After
Screenshot 2023-12-21 at 13 29 28
Before
Screenshot 2023-12-21 at 13 37 50
After
Screenshot 2023-12-21 at 13 48 21
Before
Screenshot 2023-12-21 at 13 46 18
After
Screenshot 2023-12-21 at 13 46 59
Before
Screenshot 2023-12-21 at 13 19 18
After
Screenshot 2023-12-21 at 13 18 46
Before
Screenshot 2023-12-21 at 13 50 40
After
Screenshot 2023-12-21 at 13 50 58

@scruffian scruffian self-assigned this Dec 21, 2023
@scruffian scruffian changed the title Update/navigation alignment 2 Update Navigation Alignment for popular themes Dec 21, 2023
@iamtakashi
Copy link
Copy Markdown
Contributor

I personally prefer the left-aligned navigation, so 👍 from me. Some users who liked the right-aligned nav might complain, though.

I am pinging other theme authors @beafialho @henriqueiamarino for input.

@beafialho
Copy link
Copy Markdown
Collaborator

I also prefer the left-aligned navigation as default 👍

I know this is outside the scope of this PR, but just throwing in an ideal scenario for the future: being able to choose whether navigation menu items on overlay are left or right aligned.

@scruffian
Copy link
Copy Markdown
Member Author

I know this is outside the scope of this PR, but just throwing in an ideal scenario for the future: being able to choose whether navigation menu items on overlay are left or right aligned.

We were looking at this in WordPress/gutenberg#55657 but it's got stuck so I thought a quick fix would be good for now.

@jeffikus
Copy link
Copy Markdown
Contributor

These themes are active on production sites - this isn't a fix for those people imo. This is a visual change and they could see this as a regression. They should be able to retain their existing alignment, while fixing it to the intended style.

@ianstewart
Copy link
Copy Markdown
Contributor

Some users who liked the right-aligned nav might complain, though.

These themes are active on production sites - this isn't a fix for those people imo. This is a visual change and they could see this as a regression. They should be able to retain their existing alignment, while fixing it to the intended style.

Plus one.

@scruffian scruffian closed this Dec 22, 2023
@scruffian scruffian deleted the update/navigation-alignment-2 branch December 22, 2023 17:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants