[PLTFRM-1567] Fix corrupter roles querying when viewing the user list

[andrea-sdl]

Description

NOTE: This PR has issues with the tests on a multisite environment. "as if" the fix isn't working. I can confirm it's working locally but can't figure out a way to make the unit tests work properly. Don't merge this PR until tests are fixed. Comments are welcome.

Followup to #99

While working on some new stuff, I noticed we were still having issues navigating the interface if we had broken roles, when using the Inactive User module in the "BLOCK" setting.

This PR adds additional corrupted roles fixes to this scenario to ensure everything works (and adds some tests to ensure we catch this )

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

• This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
• This change has relevant unit tests (if applicable).
• This change has relevant documentation additions / updates (if applicable).
• I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

• VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

• follow the steps in [PLTFRM-1567 & PLTFRM-1784] Add a role sanitizer to fix common corrupted roles scenarios #99 to break your roles for an inactive user.
• Set your WordPress Security Controls to block inactive accounts, making sure your broken user belongs to that group (as in: it's being inactive for enough time and the role is one that's covered

* Go into the user list page and ensure everything works. Then click on the "Blocked users" link, and again, the page should show with no errors (see below)

[Copilot]

Pull Request Overview

This PR adds resilience testing for handling corrupted user roles in the inactive users functionality. It introduces a new test class that runs all existing InactiveUsers tests with deliberately corrupted role data to ensure the system can handle database corruption scenarios gracefully.

Key Changes

• Added comprehensive test coverage for corrupted role data scenarios (missing 'name' keys, malformed 'capabilities')
• Integrated Role_Sanitizer into the inactive users module to handle role corruption at query time
• Implemented try-finally blocks to ensure Role_Sanitizer cleanup happens reliably

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File	Description
tests/phpunit/test-inactive-users-corrupted.php	New test class that extends InactiveUsersTest and runs all tests with corrupted role data, including custom error handler to suppress expected warnings
modules/inactive-users/class-inactive-users.php	Integrated Role_Sanitizer calls into blocked users view and filter logic to handle corrupted roles when querying inactive users

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.