Comment: Send announce for all new comments

[obenland]

Fixes #1001.

Proposed changes:

• Creates an Announce outbox item for every incoming comment.

Testing instructions:

• Apply this change to a WP test site that's accessible online.
• Comment on a post from a fediverse instance of your choice.
• Check the Outbox and make sure it created an Announce activity.

Changelog entry

• Automatically create a changelog entry from the details below.

Changelog Entry Details

Significance

• Patch
• Minor
• Major

Type

• Added - for new features
• Changed - for changes in existing functionality
• Deprecated - for soon-to-be removed features
• Removed - for now removed features
• Fixed - for any bug fixes
• Security - in case of vulnerabilities

Message

Incoming comments create an Announce activity so other instances get notified about it.

[obenland]

I guess this could create quite a bit of load on sites with lots of followers that comment a lot. Is that something we need to be concerned about?

[db0]

If @obenland comment is a concern, maybe a switch to turn it off.

[pfefferle]

This makes only sense if you use the ACTIVITYPUB_ACTOR_AND_BLOG_MODE and the Announce should always done by the Blog-User.

Suggested change

	/* @ticket https://github.com/Automattic/wordpress-activitypub/issues/1001 */
	add_to_outbox( $activity, 'Announce', $user_id, ACTIVITYPUB_CONTENT_VISIBILITY_PUBLIC );
	/* @ticket https://github.com/Automattic/wordpress-activitypub/issues/1001 */
	if ( ACTIVITYPUB_ACTOR_AND_BLOG_MODE === \get_option( 'activitypub_actor_mode' ) ) {
	add_to_outbox( $activity, 'Announce', Actors::BLOG_USER_ID, ACTIVITYPUB_CONTENT_VISIBILITY_PUBLIC );
	}

I would also recommend to only boost the Object-ID URL instead of the complete Activity. Not sure though if that is enough information.

[pfefferle]

Suggested change

	use Activitypub\Collection\Interactions;
	use Activitypub\Collection\Actors;
	use Activitypub\Collection\Interactions;

[obenland]

Closing for now until we have a better understanding what's needed here. See #1001 (comment)

[pfefferle]

Let's keep it open and set to WIP instead!

[pfefferle]

@obenland have you tested it with the changes I suggested?

[pfefferle]

We would also need to respect the moderation queue and only announce reactions that are published on the blog.

[pfefferle]

closed in favour of #1562