Skip to content

Fix: Missing Actor in Outbox-Activities#1564

Merged
pfefferle merged 3 commits intotrunkfrom
fix/outbox-activities
Apr 10, 2025
Merged

Fix: Missing Actor in Outbox-Activities#1564
pfefferle merged 3 commits intotrunkfrom
fix/outbox-activities

Conversation

@pfefferle
Copy link
Member

@pfefferle pfefferle commented Apr 10, 2025 •
edited
Loading

In some cases the Actor of an Activity will not properly set and we wrongly set the inReplyTo for the Activity.

These fixes are cherry picked from #1562

Proposed changes:

  • Add Actor before storing the Activity in the Outbox
  • Add Actor before federating the Activity (for backwards compatibility)
  • Remove reply-to from Activity context

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Publish a post
  • Check outbox item if Activity has an Actor

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

Ensure that an Activity is properly built before adding it to the Outbox.

@pfefferle pfefferle self-assigned this Apr 10, 2025
@pfefferle pfefferle requested a review from obenland April 10, 2025 13:49
obenland
obenland reviewed Apr 10, 2025
View reviewed changes
Copy link
Member

@obenland obenland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some cases the Actor of an Activity will not properly set.

Do we know which cases those are?

@pfefferle
Copy link
Member Author

pfefferle commented Apr 10, 2025 •
edited
Loading

If you use the add_to_outbox() and let the function build the Activity, like with add_to_outbox( $activity, 'Announce', $id ).

@pfefferle pfefferle merged commit 1dbcc8e into trunk Apr 10, 2025
11 checks passed
@pfefferle pfefferle deleted the fix/outbox-activities branch April 10, 2025 15:49
jsit added a commit to jsit/wordpress-activitypub that referenced this pull request Nov 1, 2025
@jsit
Merge tag '5.7.0' into fix/nicename
fd1508e 
* tag '5.7.0': (29 commits)
  Release 5.7.0 (Automattic#1574)
  Fix: Show error if site uses "Almost Pretty Permalink" structure (Automattic#1570)
  Admin: Add padding to extra fields nav links (Automattic#1569)
  Signature: Add compat for more key encodings (Automattic#1557)
  Reply block: Improve fallback embed (Automattic#1560)
  Add label for "Health Check" and "REST API" (Automattic#1571)
  change changelog items (Automattic#1572)
  Transformers: Allow setting properties to false. (Automattic#1567)
  Upgrades: Delete orphaned extra fields (Automattic#1566)
  Fix: Missing Actor in Outbox-Activities (Automattic#1564)
  Outbox: Properly handle username requests (Automattic#1559)
  Import: Load on admin_init (Automattic#1561)
  Move: support same-server domain migrations (Automattic#1530)
  Follow Me: add a button-only mode (Automattic#1133)
  Tests: Convert timestamp to int for comparison (Automattic#1556)
  Reply: Make Mastodon embeds work (Automattic#1555)
  Add: `Vary` header settings (Automattic#1552)
  Actors: Don't convert non-numeric strings to Blog user id (Automattic#1554)
  Add: Shared Inbox setting (Automattic#1553)
  Add: New Health checks (Automattic#1524)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@obenland obenland obenland approved these changes

Assignees

@pfefferle pfefferle

Labels

[Feature] Collections

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pfefferle @obenland @matticbot