Skip to content

Enable RFC 9421 signature by default #2859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
obenland wants to merge 6 commits into
base: trunk
Choose a base branch
from
Open

Enable RFC 9421 signature by default #2859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
175ff36
Enable RFC 9421 signature by default
obenland Feb 2, 2026
ab2eec7
Add changelog
matticbot Feb 2, 2026
f4d2313
Use string default '1' in get_option calls
obenland Feb 2, 2026
e564cf5
Fix test to explicitly use Draft Cavage signature
obenland Feb 2, 2026
56b08ba
Merge branch 'trunk' into update/rfc9421-default-on
pfefferle Feb 9, 2026
4456b62
Merge branch 'trunk' into update/rfc9421-default-on
pfefferle Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .github/changelog/2859-from-description
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: changed

Enable RFC 9421 HTTP Message Signatures by default.
2 changes: 1 addition & 1 deletion includes/class-options.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ public static function register_settings() {
array(
'type' => 'boolean',
'description' => 'Use RFC-9421 signature.',
'default' => false,
'default' => true,
)
);

Expand Down
2 changes: 1 addition & 1 deletion includes/class-signature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ public static function sign_request( $args, $url ) {
return $args;
}

if ( '1' === \get_option( 'activitypub_rfc9421_signature' ) && self::could_support_rfc9421( $url ) ) {
if ( '1' === \get_option( 'activitypub_rfc9421_signature', '1' ) && self::could_support_rfc9421( $url ) ) {
$signature = new Http_Message_Signature();
} else {
$signature = new Http_Signature_Draft();
Expand Down
2 changes: 1 addition & 1 deletion includes/wp-admin/class-advanced-settings-fields.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ public static function render_authorized_fetch_field() {
* Render RFC-9421 signature field.
*/
public static function render_rfc9421_signature_field() {
$value = \get_option( 'activitypub_rfc9421_signature', '0' );
$value = \get_option( 'activitypub_rfc9421_signature', '1' );
?>
<p>
<label>
Expand Down
4 changes: 4 additions & 0 deletions tests/phpunit/tests/includes/class-test-signature.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,9 @@ public function test_unsupported_ec_curve_for_hs2019() {
* @covers ::verify_http_signature
*/
public function test_verify_http_signature_with_digest() {
// Ensure Draft Cavage signature is used for this test.
\update_option( 'activitypub_rfc9421_signature', '0' );

// Create a user and get their keypair.
$keys = Actors::get_keypair( 1 );

Expand Down Expand Up @@ -352,6 +355,7 @@ public function test_verify_http_signature_with_digest() {
$this->assertTrue( Signature::verify_http_signature( $request ) );

\remove_filter( 'activitypub_pre_http_get_remote_object', $mock_remote_key_retrieval );
\delete_option( 'activitypub_rfc9421_signature' );
}

/**
Expand Down