Skip to content

Fix proxyUrl with urldecode in sanitize and validate callbacks before… #2957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pfefferle merged 3 commits into from
Feb 21, 2026
+18 −3
Merged

Fix proxyUrl with urldecode in sanitize and validate callbacks before… #2957

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f465555
Fix proxyUrl with urldecode in sanitize and validate callbacks before…
mediaformat Feb 21, 2026
7f9396a
class-proxy-controller.php aktualisieren
pfefferle Feb 21, 2026
183a6c2
class-proxy-controller.php aktualisieren
pfefferle Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions includes/rest/class-proxy-controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public function register_routes() {
'description' => 'The URI of the remote ActivityPub object to fetch.',
'type' => 'string',
'required' => true,
'sanitize_callback' => 'sanitize_url',
'sanitize_callback' => array( $this, 'sanitize_url' ),
'validate_callback' => array( $this, 'validate_url' ),
),
),
Expand All @@ -65,6 +65,18 @@ public function register_routes() {
);
}

/**
* Sanitizes the URL parameter.
*
* @see https://developer.wordpress.org/reference/functions/sanitize_url/
*
* @param string $url The urlencoded URL to sanitize.
* @return string The sanitized URL.
*/
public function sanitize_url( $url ) {
// Decode and sanitize the URL.
return sanitize_url( urldecode( $url ) );
}
/**
* Validate the URL parameter.
*
Expand All @@ -76,13 +88,16 @@ public function register_routes() {
* @return bool True if valid, false otherwise.
*/
public function validate_url( $url ) {
// Decode the url.
$decoded_url = urldecode( $url );

// Must be HTTPS.
if ( 'https' !== \wp_parse_url( $url, PHP_URL_SCHEME ) ) {
if ( 'https' !== \wp_parse_url( $decoded_url, PHP_URL_SCHEME ) ) {
return false;
}

// Use WordPress built-in validation (blocks local IPs, restricts ports).
return (bool) \wp_http_validate_url( $url );
return (bool) \wp_http_validate_url( $decoded_url );
}

/**
Expand Down
Loading