Closed
Conversation
The License URI points to https://www.gnu.org/licenses/gpl-2.0.html, which is the GPL v2 license text. Update the License declaration to GPL-2.0 so the SPDX identifier and the URI agree.
1 task
Contributor
|
Is the intention to stick to the GPL 2 and disallow GPL 3 usage? WP itself is 2.0-or-later. |
Member
Author
|
Oh is it? I thought core is strict 2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
The
License URIin bothatmosphere.phpandreadme.txtpoints to https://www.gnu.org/licenses/gpl-2.0.html — the canonical GPL v2 license text. Update theLicensedeclaration fromGPL-2.0-or-latertoGPL-2.0so the SPDX identifier matches the URI it links to.Replaces #36 (which addressed the same mismatch by updating the URI to SPDX's "or later" page; this PR aligns the declaration with the URI instead).
Other information:
Testing instructions:
License: GPL-2.0appears in bothatmosphere.php(header docblock) andreadme.txt.License URIcontinues to point to https://www.gnu.org/licenses/gpl-2.0.html in both files.