Move creating new endpoints to a skill#1193
Merged
Merged
Conversation
Contributor
Author
|
It's not a literal cut-and-paste. I asked Claude to move that part to a skill, the skill-creator skill kicked in and created the skill, and I think it made some adjustments, judging from the diff stat. |
jkmassel
approved these changes
Feb 25, 2026
Contributor
jkmassel
left a comment
There was a problem hiding this comment.
Seems good - I also asked Claude to make suggestions based on recent PR review comments I've made to see if there'd be anything useful in there. Here's what it came up with:
Actionable insights from your reviews:
- Prefer strong types over raw strings (PR #1147) — You suggested a ParsedUrl type instead of raw String for URLs. The skill should emphasize favoring strongly-typed wrappers beyond just IDs, e.g. for URLs, dates, or other structured data.
- Handle WordPress/PHP quirks in deserialization (PR #1136) — PHP can produce non-sequential array indices in query params (status[0]=...&status[4]=...). The skill should note that when deserializing responses or query params, be aware of PHP serialization quirks and handle them robustly.
- Consistency across similar endpoints (PR #1131) — You flagged "match the endpoints from the last PR" — when adding a new endpoint that's similar to an existing one, follow the same patterns (defaults, parameter handling, etc.) as the prior implementation.
- Avoid redundant tests (PR #1131) — "Does this need to be its own test? It seems to be mostly covered by the test above – should we add more parameters to it?" The skill's testing guidance should emphasize combining test cases where possible rather than creating near-duplicate tests.
- Error messages must include underlying details (PR #1130) — When localizing or wrapping errors, always include the underlying error message/detail so debugging is possible.
Contributor
Author
|
I'll merge this PR as is. We can probably refine it if we run into issues when using it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move the part about creating new endpoints to a skill, which trims claude.md from 2.7 tokens to 700 tokens.