Skip to content

Add Send Message to Nodes long-press context menu#374

Merged
Avi0n merged 4 commits into
Avi0n:devfrom
romeomont:feature/contact-send-message-context-menu
Jul 20, 2026
Merged

Add Send Message to Nodes long-press context menu#374
Avi0n merged 4 commits into
Avi0n:devfrom
romeomont:feature/contact-send-message-context-menu

Conversation

@romeomont

Copy link
Copy Markdown

Description

Adds a Send Message item to the Nodes long-press context menu, discussed in #372. Split out from #373 into its own PR at the maintainer's request so each change can be reviewed independently.

Long-pressing a chat contact in the Nodes/Contacts list currently shows Delete, Block/Unblock, and Favorite/Unfavorite, but no quick way to jump into the conversation — you have to open Contact Detail first.

Overview of Changes

  • MC1/Views/Contacts/ContactContextMenuModifier.swift: added a Send Message item at the top of the long-press menu, shown only for chat-type, non-blocked contacts. Reuses the existing appState.navigation.navigateToChat(with:) action and the same connection-state gating (disabled(!isConnected)) already used for the equivalent button in ContactDetailView's action row.

No other files touched — single, focused change.

Testing

  • xcodebuild build -project MC1.xcodeproj -scheme MC1 -destination 'platform=iOS Simulator,name=iPhone 17e,OS=26.5'BUILD SUCCEEDED, isolated on this branch (no other pending changes).
  • swiftlint lint — clean, no warnings/errors.
  • Have not yet manually exercised the long-press menu against a live connected radio — no physical MeshCore hardware available in this environment. Would appreciate a manual pass on-device before merge.

Tested on

  • iOS 26.5 (Simulator, build only, no paired radio)
  • iPadOS
  • macOS

Checklist

  • This PR was discussed with the maintainer either via GitHub issue or other means (Also check the box if this PR is small enough not to need discussion e.g. typo fix) — issue Contact profile pictures + "Send Message" in Nodes context menu #372 was filed but the maintainer has not yet responded
  • I have read CONTRIBUTING.md
  • Testing steps are documented above.
  • This change is not low effort and I took the time to test it

Avi0n and others added 3 commits July 12, 2026 14:34
Long-pressing a chat contact in the Nodes list showed Delete,
Block/Unblock, and Favorite/Unfavorite, but no quick way to jump into
the conversation without first opening Contact Detail. Adds a Send
Message item at the top of the menu for chat-type, non-blocked
contacts, reusing the same navigateToChat action and gating already
used in Contact Detail's action row.

See discussion: Avi0n#372

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@romeomont romeomont mentioned this pull request Jul 19, 2026
7 tasks
@Avi0n
Avi0n changed the base branch from main to dev July 20, 2026 05:30
Resolve ContactContextMenuModifier conflict by keeping both:
- Send Message menu item for chat contacts (this PR)
- V-contact delete gate from dev (ZephCore admin CLI protection)
@Avi0n

Avi0n commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Looks great, thanks for your contribution :)

@Avi0n
Avi0n merged commit e140dca into Avi0n:dev Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants