fix(l10n): add missing contact avatar strings to Italian locale#375
Closed
romeomont wants to merge 1 commit into
Closed
fix(l10n): add missing contact avatar strings to Italian locale#375romeomont wants to merge 1 commit into
romeomont wants to merge 1 commit into
Conversation
it.lproj was added in a separate commit around the same time as Avi0n#373 and was missed when the contacts.detail.avatar.* keys were backfilled to every other non-English locale. English placeholders, matching the pattern used for the other locales.
Owner
|
Sorry for that review comment on 373, I quickly deleted it because I decided to add it on my own after merge. I had just pushed commit d9e76ac to address this, so I'll close this PR. Thanks again for your contributions on 373 and 374! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds the five
contacts.detail.avatar.*localization keys (from #373) to the Italian (it.lproj) locale.Overview of Changes
it.lproj/Contacts.stringswas added in a separate commit around the same time #373 was in review. When #373 backfilled the avatar strings to every non-English locale per review feedback,itdidn't exist yet in the branch it was based on, so it was missed. This adds the same English-placeholder keys already present inde,es,fr,nl,pl,ru,uk, andzh-Hans.MC1/Resources/Localization/it.lproj/Contacts.strings: addedcontacts.detail.avatar.chooseSource,.choosePhoto,.chooseFile,.removePhoto,.savingAnnouncement,.invalidImage, matching the placement and English-placeholder pattern used in the other locale files.Testing
xcodebuild build -project MC1.xcodeproj -scheme MC1 -destination 'platform=iOS Simulator,name=iPhone 17e,OS=26.5'— BUILD SUCCEEDEDswiftlint lint— 0 violationsswiftformat --lint --strict .— cleanTested on
Checklist
CONTRIBUTING.md