This repository was archived by the owner on Jun 17, 2025. It is now read-only.
WIP: Feature/update react and storybook#1135
Draft
Coldknife2 wants to merge 2 commits intoAxaFrance:masterfrom
Draft
WIP: Feature/update react and storybook#1135Coldknife2 wants to merge 2 commits intoAxaFrance:masterfrom
Coldknife2 wants to merge 2 commits intoAxaFrance:masterfrom
Conversation
added 2 commits
April 5, 2024 12:05
MartinWeb
reviewed
Apr 5, 2024
|
|
||
| const handleChangeItems = useCallback( | ||
| (e) => | ||
| (e: any) => |
Contributor
There was a problem hiding this comment.
celui ci j'avais réussi à le typer (e: {value: number})
Author
There was a problem hiding this comment.
Oui je me suis pas embêté pour ces erreurs là, il doit y avoir moyen de mieux les typer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to latest react version and change eslint configs accordingly
Tests corrected, all green
Update storybook to 7 => broken atm, WIP
NavBar.spec.tsx=> deleted 2 tests I judge non relevant, explanation provided in comments on fileremove
storybook-readme(https://storybook.js.org/addons/storybook-readme) => not updated for 3 years, not compatible with storybook 7+Current state of PR :
Tests are ok
Builds correctly
Storybook starts, but content is broken, due to the removal of
storybook-readmeMaybye this PR => #1022
could help migrate to .mdx files and fix the problem