-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add conditional inputs to js-lints #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+37
−8
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -14,7 +14,7 @@ The following reusable workflows are available for consumption by downstream plu | |||||
| | [reusable-phpcs.yml](reusable-phpcs.yml) | Run PHPCS coding standards | `php-version` | | ||||||
| | [reusable-e2e.yml](reusable-e2e.yml) | Run Playwright E2E tests | `php-version` | | ||||||
| | [reusable-jest.yml](reusable-jest.yml) | Run Jest unit tests | `coverage` | | ||||||
| | [reusable-lint-js.yml](reusable-lint-js.yml) | Run ESLint, Stylelint, Prettier, TSC | None | | ||||||
| | [reusable-js-lints.yml](reusable-js-lints.yml) | Run ESLint, Stylelint, Prettier, TSC | None | | ||||||
| | [reusable-build.yml](reusable-build.yml) | Build plugin artifact | `php-version`, `artifact-name`, `artifact-path` | | ||||||
| | [reusable-wp-playground-pr-preview.yml](reusable-wp-playground-pr-preview.yml) | Post WP Playground preview | `run-id`, `artifact-prefix`, `artifact-filename`, `artifacts-to-keep` | | ||||||
|
|
||||||
|
|
@@ -92,11 +92,15 @@ Runs Jest unit tests for JavaScript. | |||||
| - **Secrets:** | ||||||
| - `CODECOV_TOKEN` (optional): Token for uploading coverage to Codecov. | ||||||
|
|
||||||
| ### reusable-lint-js.yml | ||||||
| ### reusable-js-lints.yml | ||||||
|
|
||||||
| Runs ESLint, Stylelint, Prettier, and TypeScript checks. | ||||||
|
|
||||||
| - **Inputs:** None. | ||||||
| - **Inputs:** | ||||||
| - `eslint` (boolean, default: `true`): Run ESLint. | ||||||
| - `stylelint` (boolean, default: `true`): Run Stylelint. | ||||||
| - `prettier` (boolean, default: `true`): Run Prettier. | ||||||
| - `tsc` (boolean, default: `true`): Run TypeScript | ||||||
|
||||||
| - `tsc` (boolean, default: `true`): Run TypeScript | |
| - `tsc` (boolean, default: `true`): Run TypeScript. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reusable-js-lints workflow now accepts boolean inputs (eslint/stylelint/prettier/tsc), but the Inputs column in the reusable workflows table still says "None". Please update this table entry to reflect the available inputs so consumers don’t miss the new controls.