Open
Conversation
rpdp headers are not part of the ROOT public API and thus should not be visible in include/. They were simply because multiple ROOT modules were including them, and we had no way to specify that other than publishing them. Now we have a new directory next to src/ and inc/: res/ (as in "reserved" or "restricted"), signalling that these headers are not public but used by other ROOT modules. Update the Moduke.mk-s accordingly. Move a few really private headers into their src/ directories.
Axel-Naumann
force-pushed
the
master
branch
2 times, most recently
from
b40fdd0 to
dd25999
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rpdp headers are not part of the ROOT public API and thus should not
be visible in include/. They were simply because multiple ROOT modules
were including them, and we had no way to specify that other than
publishing them. Now we have a new directory next to src/ and inc/:
res/ (as in "reserved" or "restricted"), signalling that these headers
are not public but used by other ROOT modules.
Update the Moduke.mk-s accordingly.
Move a few really private headers into their src/ directories.