Add require_categories DSL and fix ActiveSupport dependency#1
Merged
DmitrySychev merged 1 commit intomainfrom Apr 5, 2026
Merged
Add require_categories DSL and fix ActiveSupport dependency#1DmitrySychev merged 1 commit intomainfrom
DmitrySychev merged 1 commit intomainfrom
Conversation
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
- Add `require_categories true` DSL macro: when set, multi-label classifiers return Result.failure when no valid categories are found (previously multi-label always returned success with empty array) - Fix .blank? call in Web content fetcher's normalize_redirect_url that required ActiveSupport. Replaced with nil/empty check. - Bump version to 0.2.0 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
fa35b84 to
93b7b91
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
require_categories trueDSL macro for multi-label classifiers that should fail when no categories match.blank?ActiveSupport dependency in Web content fetcherDetails
require_categories
Multi-label classifiers previously always returned
Result.successeven with an empty categories array. This made it impossible to distinguish "the LLM found no matching categories" from "classification succeeded with results.".blank? fix
ContentFetchers::Web#normalize_redirect_urlcalled.blank?which is an ActiveSupport method. Replaced withnil? || empty?so the gem works without Rails/ActiveSupport.