[#4060] Align completeness between old Aggregate and new Entity description#4562
Merged
Conversation
laura-devriendt-lemon
added
Priority 1: Must
laura-devriendt-lemon
requested review from
MateuszNaKodach,
hjohn and
jangalinski
and removed request for
a team
laura-devriendt-lemon
changed the title
smcvb
changed the title
smcvb
requested changes
May 11, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Thanks for picking up this task, @laura-devriendt-lemon! I do have quite some comments to address, though. Arguable quite some I could've clarified on the original issue...so my apologies for that. So, please bare with me here! 🙏
Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
hatzlj
reviewed
May 13, 2026
Contributor
hatzlj
left a comment
hatzlj
left a comment
There was a problem hiding this comment.
I have one concern regarding the handling of sealed types for polymorphic models and some minor improvement suggestions. Overall it reads great and easy to follow.
smcvb
requested changes
May 15, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
Sorry, bunch of comments to cover again. I think we need to do a bit more restructuring of the command-handlers.adoc and event-sourced-entity.adoc pages mostly.
smcvb
requested changes
May 21, 2026
Contributor
smcvb
left a comment
smcvb
left a comment
There was a problem hiding this comment.
The structure is shaping up nicely; thanks! From here, the pointers are a bit more specific for structure. To generalize, the following are my biggest concerns:
- I feel a misaligned in the structure of
event-sourced-entity.adoc,entity-creator.adoc,entity-hierarchies.adoc, andentity-polymorphism.adoc. I'd hope that each would have a configuration-agnostic example first. This section should not mention details like annotations at all, but only use the conceptual terms. This is then followed up by the three configuration options we have, being declarative, automated, and Spring Boot. - Section that build on previous examples should not repeat what those previous example state, but refer to them. This will make our examples a lot more concise, with the intend to make it more comprehensible for the reader
- The
command-handler-components.adocshould talk about the "Stateful Command Handlers", as command handlers that have the state inject are the stateful command handlers. As such, the intro andcommand-handlers.adocshould align with that terminology.
# Conflicts: # docs/reference-guide/modules/migration/pages/paths/aggregates/configuration-migration.adoc
hatzlj
approved these changes
May 28, 2026
Contributor
hatzlj
left a comment
hatzlj
left a comment
There was a problem hiding this comment.
Structure wise i think it looks very nice now. There are some minor suggestions you can include without the need for a re-review before merging this.
…eator.adoc Co-authored-by: Jakob Hatzl <hatzlj@users.noreply.github.com>
…eator.adoc Co-authored-by: Jakob Hatzl <hatzlj@users.noreply.github.com>
…eator.adoc Co-authored-by: Jakob Hatzl <hatzlj@users.noreply.github.com>
…configuration-migration.adoc Co-authored-by: Jakob Hatzl <hatzlj@users.noreply.github.com>
…erarchies.adoc Co-authored-by: Jakob Hatzl <hatzlj@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #4060.