Add figma-style dragging on editor#152
Draft
peculiarnewbie wants to merge 4 commits intoAzgaar:masterfrom
Draft
Conversation
Azgaar
reviewed
Mar 6, 2024
Author
|
moved implementation directly on now also works with rotation and ordinary |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for now i just added it to the size input field
the first commit is a naive implementation where you just change the input value on drag. It's very expensive because of all the side effects on those input fields changing
the second commit is implemented using the existing editor drag function, altoughi had to add minor changes outside of the component itself