Skip to content

Remove homebrew from specials dirs since it is too general#50

Merged
AzisK merged 2 commits intomainfrom
Remove-homebrew-from-specials-dirs-since-it-is-too-general
Apr 5, 2026
Merged

Remove homebrew from specials dirs since it is too general#50
AzisK merged 2 commits intomainfrom
Remove-homebrew-from-specials-dirs-since-it-is-too-general

Conversation

@AzisK
Copy link
Copy Markdown
Owner

@AzisK AzisK commented Mar 18, 2026

Add mypy to pre-commit

Summary by CodeRabbit

  • Chores
    • Added mypy to pre-commit checks to enforce type checking.
    • Removed "homebrew" from the set of recognized package cache directories.
  • Tests
    • Updated unit tests to remove the assertion that "Homebrew" maps to the package cache category.

@github-actions
Copy link
Copy Markdown

⸜(。˃ ᵕ ˂ )⸝♡ Thank you for opening this Pull Request, AzisK!

( ˶°ㅁ°) !! It's Trivia Time!

Here are 3 trivia questions to keep you entertained while CI runs.
(Feel free to demonstrate your knowledge and reply!)

🧩 Q1: What was the original name of Ho Chi Minh City?

A) Angkor Wat
B) Saigon
C) Hanoi
D) Dar Es Salaam

🧩 Q2: What is the real hair colour of the mainstream comic book version (Earth-616) of Daredevil?

A) Blonde
B) Black
C) Brown
D) Auburn

🧩 Q3: Which of these places is a location in Cornwall?

A) Barcelona
B) Alicante
C) Madrid
D) Lisbon

You got this! Remember, every bug is just a feature in disguise.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9679d932-7268-4d78-bd2c-2d75074cabd0

📥 Commits

Reviewing files that changed from the base of the PR and between 271c43c and d47899c.

📒 Files selected for processing (1)
  • test_unit.py
💤 Files with no reviewable changes (1)
  • test_unit.py

📝 Walkthrough

Walkthrough

Adds a mypy pre-commit hook (with types-tqdm), removes "homebrew" from DEFAULT_SPECIAL_DIRS package caches, and reorders imports in core.py to import DEFAULT_TOP_N from zpace.config.

Changes

Cohort / File(s) Summary
Pre-commit Configuration
.pre-commit-config.yaml
Adds mypy hook from pre-commit/mirrors-mypy at v1.19.1, includes types-tqdm as an additional dependency.
Configuration
zpace/config.py
Removes the "homebrew" entry from the Package Caches set inside DEFAULT_SPECIAL_DIRS.
Core Imports
zpace/core.py
Reorders imports and adds DEFAULT_TOP_N to imports from zpace.config; no other functional changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐇 A hop for types, a tidy spree,
Homebrew's gone from cache and tree,
Imports nudged to find their place,
Pre-commit checks now join the race,
I nibble bugs with gentle grace.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing homebrew from special directories. However, it only addresses one of two significant changes in the PR, as mypy is also being added to pre-commit configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • ✅ Generated successfully - (🔄 Check to regenerate)
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch Remove-homebrew-from-specials-dirs-since-it-is-too-general
📝 Coding Plan
  • ❌ Error while generating coding plan for human review comments - (🔄 Check again to try again)

Comment @coderabbitai help to get the list of available commands and usage tips.

Tip

You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.

Change the reviews.profile setting to assertive to make CodeRabbit's nitpick more issues in your PRs.

@github-actions
Copy link
Copy Markdown

🎉 All tests passed! Here's a dog for you! 🐶

Dog

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 18, 2026

No open human review comments were found in this PR to create a plan for.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 5, 2026

Caution

Docstrings generation - FAILED

No docstrings were generated.

@AzisK AzisK merged commit 5c790e9 into main Apr 5, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant