Fix rounding error which causes aspect ratio to not be retained#24
Open
johnnyoshika wants to merge 1 commit intoAzure-Samples:masterfrom
Open
Fix rounding error which causes aspect ratio to not be retained#24johnnyoshika wants to merge 1 commit intoAzure-Samples:masterfrom
johnnyoshika wants to merge 1 commit intoAzure-Samples:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To reproduce the error, try uploading an image that's 1024x1024 pixels, then resize to 900px width. The width will be 900px but the height will be calculated as 1024px, because the divisor will be 1 due to integer truncation.
The fix is: