Skip to content

Add node taint config#137

Merged
wenxuan0923 merged 1 commit intomainfrom
wenx/taint-support
Apr 2, 2026
Merged

Add node taint config#137
wenxuan0923 merged 1 commit intomainfrom
wenx/taint-support

Conversation

@wenxuan0923
Copy link
Copy Markdown
Collaborator

Allows flex node operators to specify taints in the agent config alongside existing labels. Taints are applied at node registration time so the node is properly tainted from the moment it joins the cluster.

@wenxuan0923 wenxuan0923 marked this pull request as ready for review April 2, 2026 17:16
Copilot AI review requested due to automatic review settings April 2, 2026 17:16
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for configuring Kubernetes node taints in the agent config and ensures they’re applied at kubelet registration time via --register-with-taints, so nodes join the cluster already tainted.

Changes:

  • Add node.taints to the agent config model and ensure it is deep-copied safely.
  • Plumb taints through bootstrapper → kubelet start action spec and into the systemd kubelet drop-in template.
  • Extend the kubelet component proto (StartKubeletServiceSpec) with register_with_taints.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pkg/config/structs.go Adds NodeConfig.Taints config field and documents expected taint string format.
pkg/config/copy.go Updates Config.DeepCopy() to clone the taints slice to avoid shared backing arrays.
pkg/config/copy_test.go Adds test coverage to ensure Node.Taints is not shared between original and copied config.
pkg/bootstrapper/components.go Plumbs config taints into kubelet start spec and ensure-machine spec via defensive slice copy.
components/kubelet/v20260301/kubelet_service.go Renders --register-with-taints into kubelet systemd drop-in parameters.
components/kubelet/v20260301/assets/20-flex-node-node-config.conf Adds conditional --register-with-taints=... to kubelet env args.
components/kubelet/action.proto Adds repeated string register_with_taints = 5 to StartKubeletServiceSpec.
components/kubelet/action.pb.go Regenerates Go bindings to include the new proto field.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@wenxuan0923 wenxuan0923 merged commit e8ffb2e into main Apr 2, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants