Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for configuring Kubernetes node taints in the agent config and ensures they’re applied at kubelet registration time via --register-with-taints, so nodes join the cluster already tainted.
Changes:
- Add
node.taintsto the agent config model and ensure it is deep-copied safely. - Plumb taints through bootstrapper → kubelet start action spec and into the systemd kubelet drop-in template.
- Extend the kubelet component proto (
StartKubeletServiceSpec) withregister_with_taints.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/config/structs.go | Adds NodeConfig.Taints config field and documents expected taint string format. |
| pkg/config/copy.go | Updates Config.DeepCopy() to clone the taints slice to avoid shared backing arrays. |
| pkg/config/copy_test.go | Adds test coverage to ensure Node.Taints is not shared between original and copied config. |
| pkg/bootstrapper/components.go | Plumbs config taints into kubelet start spec and ensure-machine spec via defensive slice copy. |
| components/kubelet/v20260301/kubelet_service.go | Renders --register-with-taints into kubelet systemd drop-in parameters. |
| components/kubelet/v20260301/assets/20-flex-node-node-config.conf | Adds conditional --register-with-taints=... to kubelet env args. |
| components/kubelet/action.proto | Adds repeated string register_with_taints = 5 to StartKubeletServiceSpec. |
| components/kubelet/action.pb.go | Regenerates Go bindings to include the new proto field. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
runzhen
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows flex node operators to specify taints in the agent config alongside existing labels. Taints are applied at node registration time so the node is properly tainted from the moment it joins the cluster.