Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Kubernetes binary download mechanism in the kubebins component to use the official Kubernetes CDN (dl.k8s.io) now that acs-mirror no longer publishes certain binaries for 1.35.x+.
Changes:
- Switch from downloading/extracting a Kubernetes node tarball to downloading individual binaries (kubeadm/kubelet/kubectl/kube-proxy) from
https://dl.k8s.io. - Download required binaries in parallel using
errgroup. - Extend
DownloadKubeBinariesStatuswith per-binary paths and per-binary download URLs; mark the olddownload_urlfield as deprecated.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| go.mod | Promotes golang.org/x/sync to a direct dependency for errgroup. |
| components/kubebins/v20260301/download.go | Implements per-binary downloads from dl.k8s.io with parallelization and updated status fields. |
| components/kubebins/action.proto | Deprecates download_url and adds per-binary status fields. |
| components/kubebins/action.pb.go | Regenerates Go protobuf output for the updated status message schema. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wenxuan0923
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since 1.35.x, acs-micrror no longer publishes binaries for kubetctl etc. Before we can finalize the binary source, we will use dl.k8s.io for now.
Related #117