Switch to grafanadatasource step#4791
Merged
openshift-merge-bot[bot] merged 3 commits intomainfrom Apr 16, 2026
Merged
Conversation
Collaborator
Author
|
Requires Azure/ARO-Tools#218 |
janboll
force-pushed
the
add-grafanadatasource
branch
from
15f2f42 to
878353b
Compare
Collaborator
Author
|
/hold needs sdp-pipelines integration |
janboll
force-pushed
the
add-grafanadatasource
branch
from
878353b to
1e73386
Compare
Collaborator
Author
|
PR in sdp-pipeline that enables this: https://dev.azure.com/msazure/AzureRedHatOpenShift/_git/sdp-pipelines/pullrequest/15387114?path=/go.work.sum |
Collaborator
|
/test e2e-parallel |
Collaborator
Author
|
/unhold |
The modify command's MonitorWorkspaceClient uses the same subscription as the Grafana instance (from the execution target). If svc/hcp monitor workspaces are ever in a different subscription than the Grafana instance, this would need revisiting. But this matches the approved design from PR 3952.
janboll
force-pushed
the
add-grafanadatasource
branch
from
1e73386 to
94321ad
Compare
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: janboll, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The modify command's MonitorWorkspaceClient uses the same subscription as the Grafana instance (from the execution target). If svc/hcp monitor workspaces are ever in a different subscription than the Grafana instance, this would need revisiting. But this matches the approved design from PR 3952.