Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Go module dependencies in the tooling/templatize and test workspaces to remediate the AWS SDK for Go v2 EventStream decoder DoS advisory.
Changes:
- Bump
github.com/aws/aws-sdk-go-v2/service/s3(and related transitive AWS SDK v2 modules) to newer versions intooling/templatizeandtest. - Bump
github.com/aws/aws-sdk-go-v2/aws/protocol/eventstreamtov1.7.8(and refresh correspondinggo.sumentries).
Reviewed changes
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tooling/templatize/go.mod | Updates AWS SDK v2-related module versions (incl. EventStream and S3). |
| tooling/templatize/go.sum | Refreshes checksums to match the updated AWS SDK v2 dependency graph. |
| test/go.mod | Mirrors the AWS SDK v2-related bumps for the test module. |
| test/go.sum | Refreshes checksums to match the updated AWS SDK v2 dependency graph. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hbhushan3, raelga The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://redhat.atlassian.net/browse/AROSLSRE-665
What
Bump
github.com/aws/aws-sdk-go-v2/service/s3from v1.87.1 to v1.99.0 andaws/protocol/eventstreamto latest in tooling/templatize, test.Why
Fixes Moderate severity advisory — "Denial of Service due to Panic in AWS SDK for Go v2 SDK EventStream Decoder".
Resolves Dependabot alerts: #184, #185, #186, #187
Supersedes Dependabot PR: #4789
Testing
go buildpassesgo mod tidycleango work synccleanSpecial notes for your reviewer
Dependency-only change, no code modifications.