ci(golangci): derive lint version from bingo pin - #4975
Open
tuxerrante wants to merge 1 commit into
Open
Conversation
tuxerrante
requested review from
alcasim,
bennerv,
cadenmarchese,
hawkowl,
hlipsig,
kevinobriendotca,
kimorris27,
mociarain,
mrWinston,
rogbas,
sankur-codes,
tiguelu,
tsatam,
ventifus,
wanghaoran1988 and
yjst2012
as code owners
July 17, 2026 07:39
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Go CI workflow to derive the golangci-lint-action version input from the bingo pin (.bingo/golangci-lint.mod), eliminating a duplicated hardcoded version in CI, and adds a short agent-guide note documenting the approach.
Changes:
- Read the golangci-lint version from
.bingo/golangci-lint.modin thegolangciGitHub Actions job and pass it intogolangci/golangci-lint-action. - Add documentation describing the version-sync approach and its intent to keep CI aligned with bingo’s pin.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/agent-guides/golangci-version-sync-note.md | Adds documentation about syncing golangci-lint version between CI and bingo. |
| .github/workflows/ci-go.yml | Derives the golangci-lint-action version input from .bingo/golangci-lint.mod instead of hardcoding it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Read the golangci-lint action version from .bingo/golangci-lint.mod, fail fast if the pin cannot be parsed, and keep the existing golangci-lint-action install/cache flow unchanged.
tuxerrante
force-pushed
the
tuxerrante/ARO-28459/golangci-version-sync
branch
from
July 17, 2026 08:22
9ce4a63 to
f16959e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lint-actionversion from.bingo/golangci-lint.modinstead of hardcoding a second pin in CI$GITHUB_OUTPUTgolangci-lint-actionand its existing install/cache behavior unchangedValidation
make validate-go-actionversion=v2.12.2Jira
ARO-28459