Skip to content

Add verification for grafana dashboards#216

Merged
stevekuznetsov merged 1 commit intomainfrom
add-dashboard-verify
Apr 7, 2026
Merged

Add verification for grafana dashboards#216
stevekuznetsov merged 1 commit intomainfrom
add-dashboard-verify

Conversation

@janboll
Copy link
Copy Markdown
Collaborator

@janboll janboll commented Apr 2, 2026

This adds a verification command to grafanactl. This will run during PR checks, to ensure Grafana Dashboards are written in a way they can be synced.

@raelga
Copy link
Copy Markdown
Contributor

raelga commented Apr 7, 2026

/lgtm
/approve

// See the License for the specific language governing permissions and
// limitations under the License.

package grafana
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't put stuff in internal. The only people who want to import this and re-use it are our team, and making it hard in a repo that is specifically supposed to be re-usable code is wierd.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nvm. All pre-existing. Sigh.

@stevekuznetsov stevekuznetsov merged commit b4710bb into main Apr 7, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants