Skip to content

chore: add agentbaker artifact streaming combo e2es#8332

Open
mxj220 wants to merge 22 commits intomainfrom
markibrahim/art-strm-combo-e2es
Open

chore: add agentbaker artifact streaming combo e2es#8332
mxj220 wants to merge 22 commits intomainfrom
markibrahim/art-strm-combo-e2es

Conversation

@mxj220
Copy link
Copy Markdown
Contributor

@mxj220 mxj220 commented Apr 16, 2026 •
edited
Loading

What this PR does / why we need it:
Adds new scenarios for artifact streaming with network isolated cluster, fips, and tl with and without scriptless.
Which issue(s) this PR fixes:

Fixes #

Copilot AI review requested due to automatic review settings April 16, 2026 21:55
Copilot AI reviewed Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new e2e scenarios to validate artifact streaming across additional security/isolation combinations (Trusted Launch, FIPS, Confidential VM, Kata), covering both AgentBaker (NBC) and scriptless (aks-node-controller) provisioning paths.

Changes:

  • Added a VMSS mutator helper to configure Confidential VM security settings on the VMSS model.
  • Added new artifact streaming e2e scenarios for:
    • Ubuntu 22.04 Gen2 Trusted Launch (with/without scriptless)
    • Ubuntu 22.04 Gen2 FIPS (with/without scriptless)
    • Azure Linux V3 Gen2 Confidential VM (with/without scriptless)
    • Azure Linux V3 Gen2 Kata (with/without scriptless)
  • Registered new VHD image definitions in e2e config for Ubuntu 22.04 TL Gen2, Azure Linux V3 CVM Gen2, and Azure Linux V3 Kata Gen2.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
e2e/test_helpers.go Adds addConfidentialVMToVMSS to set VMSS security + disk security profile for CVM scenarios.
e2e/scenario_test.go Adds new artifact streaming scenario tests for TL/FIPS/CVM/Kata with scriptless and non-scriptless variants.
e2e/config/vhd.go Adds new e2e VHD Image entries for Ubuntu 2204 TL Gen2, Azure Linux V3 CVM Gen2, and Azure Linux V3 Kata Gen2.

ganeshkumarashok
ganeshkumarashok approved these changes Apr 16, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@ganeshkumarashok ganeshkumarashok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm as long as all the new e2es pass

Copilot AI review requested due to automatic review settings April 20, 2026 15:11
Copilot AI reviewed Apr 20, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@mxj220 mxj220 force-pushed the markibrahim/art-strm-combo-e2es branch from c3828b2 to a730926 Compare April 20, 2026 15:35
Copilot AI review requested due to automatic review settings April 20, 2026 16:58
Copilot AI review requested due to automatic review settings April 21, 2026 18:58
Copilot AI reviewed Apr 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

Comment thread e2e/scenario_test.go Outdated
Comment thread e2e/scenario_test.go
Copilot AI review requested due to automatic review settings April 22, 2026 14:58
Copilot AI reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.

@mxj220
Copy link
Copy Markdown
Contributor Author

mxj220 commented Apr 23, 2026

@copilot resolve the merge conflicts in this pull request

@mxj220
fix: resolve merge conflicts with main
870dc65 
Co-authored-by: mxj220 <14959858+mxj220@users.noreply.github.com>
Copilot AI review requested due to automatic review settings April 23, 2026 19:32
@mxj220 mxj220 review requested due to automatic review settings April 23, 2026 19:32
Copy link
Copy Markdown
Contributor

Copilot AI commented Apr 23, 2026

@copilot resolve the merge conflicts in this pull request

Resolved the merge conflict in e2e/config/vhd.go — kept both VHDUbuntu2204Gen2TLContainerd (from this branch) and VHDUbuntu2004FIPSContainerd (added in main). Merged in commit 870dc65.

Copilot AI review requested due to automatic review settings April 23, 2026 21:07
Copilot AI reviewed Apr 23, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comment thread e2e/scenario_test.go Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ganeshkumarashok ganeshkumarashok ganeshkumarashok approved these changes

@cameronmeissner cameronmeissner Awaiting requested review from cameronmeissner cameronmeissner is a code owner

@Devinwong Devinwong Awaiting requested review from Devinwong Devinwong is a code owner

@lilypan26 lilypan26 Awaiting requested review from lilypan26 lilypan26 is a code owner

@AbelHu AbelHu Awaiting requested review from AbelHu AbelHu is a code owner

@junjiezhang1997 junjiezhang1997 Awaiting requested review from junjiezhang1997 junjiezhang1997 is a code owner

@djsly djsly Awaiting requested review from djsly djsly is a code owner

@phealy phealy Awaiting requested review from phealy phealy is a code owner

@r2k1 r2k1 Awaiting requested review from r2k1 r2k1 is a code owner

@timmy-wright timmy-wright Awaiting requested review from timmy-wright timmy-wright is a code owner

@zachary-bailey zachary-bailey Awaiting requested review from zachary-bailey zachary-bailey is a code owner

@awesomenix awesomenix Awaiting requested review from awesomenix awesomenix is a code owner

@pdamianov-dev pdamianov-dev Awaiting requested review from pdamianov-dev pdamianov-dev is a code owner

@calvin197 calvin197 Awaiting requested review from calvin197 calvin197 is a code owner

@sulixu sulixu Awaiting requested review from sulixu sulixu is a code owner

@surajssd surajssd Awaiting requested review from surajssd surajssd is a code owner

@SriHarsha001 SriHarsha001 Awaiting requested review from SriHarsha001 SriHarsha001 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mxj220 @ganeshkumarashok