-
Notifications
You must be signed in to change notification settings - Fork 96
feat(vscode): Add Designer V2 support+toggle, and version notification #8803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Small nit: replace + with and for clarity. |
| Commit Type | ✅ | No change needed. |
| Risk Level | ✅ | Medium is appropriate; tests added reduce risk. |
| What & Why | ✅ | Consider noting default remains V1 and any migration notes. |
| Impact of Change | ✅ | Add brief note about agent URL change and compatibility testing. |
| Test Plan | ✅ | Good — unit tests added. Consider E2E or explain why not. |
| Contributors | Optional: add contributors if applicable. | |
| Screenshots/Videos | Recommend screenshots for notification UX. |
Final Notes & Actionable Recommendations
- Title: optional tidy-up — replace
+withandfor readability. - Test Coverage: unit tests were added and look comprehensive. Still consider adding a minimal integration/E2E test or a CI smoke job that exercises webview messaging and the chat iframe flow for an Azure workflow to catch regressions in the agent/chat URL behavior.
- Release/Docs: Add a short CHANGELOG entry and a small docs note for the new setting
azureLogicAppsStandard.designerVersion(what values mean, default=1, and how users can enable V2). Also mention the version notification behavior. - Localization: You used localize() for strings in the extension. Ensure the localization files are updated if your repo requires adding the keys to a source locale resource (if applicable to your pipeline).
- Manual Test Steps: Keep the manual verification steps in the PR description. Consider adding a short checklist for reviewers to follow when validating the chat iframe scenario on Azure-hosted workflows.
- Contributors: If other team members contributed reviews or design, add them to the Contributors section for visibility.
Please update the PR with any optional changes above (screenshots, CHANGELOG, small title tweak) if you want—but the PR body is compliant with the required template and the code changes are accompanied by unit tests. Great work!
Please update the PR title/body if you want to incorporate the small recommendations above, then re-run CI. Thank you for the thorough PR and the added unit tests!
Last updated: Wed, 11 Feb 2026 22:22:09 GMT
|
📊 Coverage check completed. See workflow run for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds three main features to the VS Code extension: a Designer V2 toggle following the established Data Mapper version switching pattern, a fix for the Chat iframe not loading for Azure workflows, and a version notification popup to guide users between designer versions.
Changes:
- Adds
designerVersionsetting (default: 1) with command handlers to communicate the version between extension and webview - Fixes Chat iframe URL construction for Azure workflows by using the app's
defaultHostNamewith HTTPS instead of the management.azure.com URL - Implements notification popups when opening workflows to promote Designer V2 preview or allow users to revert to V1
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
libs/vscode-extension/src/lib/models/workflow.ts |
Added defaultHostName field to AzureConnectorDetails interface for Azure app hostname |
libs/vscode-extension/src/lib/models/extensioncommand.ts |
Added getDesignerVersion command for version communication |
apps/vs-code-react/src/webviewCommunication.tsx |
Added handler for getDesignerVersion command to update Redux state |
apps/vs-code-react/src/state/projectSlice.ts |
Added designerVersion state and changeDesignerVersion action to project slice |
apps/vs-code-react/src/run-service/types.ts |
Added GetDesignerVersionMessage interface for type safety |
apps/vs-code-react/src/app/designer/servicesHelper.ts |
Passed defaultHostName to fetchAgentUrl for Azure workflows |
apps/vs-code-react/src/app/designer/services/workflowService.ts |
Updated fetchAgentUrl to construct HTTPS URLs using defaultHostName for Azure workflows |
apps/vs-code-react/src/app/designer/services/__test__/workflowService.test.ts |
Added unit tests for URL construction logic with local and Azure scenarios |
apps/vs-code-react/src/app/designer/app.tsx |
Refactored to conditionally render V1 or V2 designer based on version setting |
apps/vs-code-designer/src/package.json |
Added azureLogicAppsStandard.designerVersion configuration setting |
apps/vs-code-designer/src/constants.ts |
Added designerVersionSetting and defaultDesignerVersion constants |
apps/vs-code-designer/src/app/commands/workflows/openMonitoringView/openMonitoringViewForLocal.ts |
Added getDesignerVersion command handler |
apps/vs-code-designer/src/app/commands/workflows/openMonitoringView/openMonitoringViewForAzureResource.ts |
Added getDesignerVersion command handler and passed defaultHostName to metadata |
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForLocalProject.ts |
Added getDesignerVersion command handler and version notification |
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerForAzureResource.ts |
Added getDesignerVersion command handler, version notification, and passed defaultHostName |
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts |
Implemented getDesignerVersion() and showDesignerVersionNotification() methods |
apps/vs-code-designer/src/app/commands/workflows/openDesigner/__test__/openDesignerBase.test.ts |
Added comprehensive unit tests for designer version logic and notifications |
apps/vs-code-react/src/app/designer/services/__test__/workflowService.test.ts
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/openDesigner/openDesignerBase.ts
Show resolved
Hide resolved
apps/vs-code-designer/src/app/commands/workflows/openDesigner/__test__/openDesignerBase.test.ts
Outdated
Show resolved
Hide resolved
apps/vs-code-react/src/app/designer/services/__test__/workflowService.test.ts
Show resolved
Hide resolved
apps/vs-code-react/src/app/designer/services/__test__/workflowService.test.ts
Outdated
Show resolved
Hide resolved
|
📊 Coverage check completed. See workflow run for details. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
📊 Coverage check completed. See workflow run for details. |
Cover all changed source files in vs-code-designer and vs-code-react that were failing the PR coverage workflow with 0% coverage. Rewrote existing tests to import actual source code, added new test files for designer commands and React components, and fixed test setup mocks. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
The coverage config only included src/app/**/* which excluded src/state/ and src/webviewCommunication.tsx from lcov reports, causing the PR coverage check to fail. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
1 similar comment
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Designer V2 Toggle
azureLogicAppsStandard.designerVersionsetting (default: 1, options: 1 or 2)ExtensionCommand.getDesignerVersionDesignerAppV1orDesignerAppV2based on settingVersion Notification
Impact of Change
designerVersionsetting andgetDesignerVersionextension command addedTest Plan
pnpm run test:extension-unit→ verify all tests passContributors
Screenshots/Videos
Recording.2026-02-10.130617.mp4