Conversation
… triggers
- Fix hasVariableReference regex to detect variables() calls nested inside other functions like substring(), length(), concat(), etc. Previously the regex required @ directly before variables, missing patterns like @{substring(variables('x'), ...)}.
- Prevent tracked properties from showing on triggers. The backend never supports tracked properties on triggers regardless of what the manifest declares.
- Added unit tests for nested variable reference patterns in both designer v1 and v2. Changes mirrored in both libs/designer and libs/designer-v2.
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Keep the current title |
| Commit Type | ✅ | fix is correct |
| Risk Level | ✅ | risk:low matches code changes |
| What & Why | ✅ | Clear and adequate |
| Impact of Change | ✅ | Clear and adequate |
| Test Plan | ✅ | Unit tests added — consider calling out file paths or CI results |
| Contributors | Optional: add contributors or acknowledge nobody contributed | |
| Screenshots/Videos | ✅ | N/A is appropriate |
Final notes
- The PR follows the required template and includes unit tests that match the changes in the diff. The risk label (
risk:low) correctly reflects the changes. - Small recommendations: add file paths or brief pointers to the tests you changed in the Test Plan to speed review (e.g.,
libs/designer/src/lib/core/parsers/__test__/combineSequentialInitializeVariables.spec.tsandlibs/designer-v2/...), and optionally list contributors.
Please update only if you want to add the optional contributors information or a short pointer to the modified test files; otherwise this PR is ready from a PR-title/body/template perspective. Thanks!
Last updated: Wed, 11 Feb 2026 18:35:34 GMT
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes two designer-side behaviors in the Logic Apps UX monorepo: (1) more reliably detecting variable-to-variable references inside nested expression functions to prevent invalid “combine InitializeVariable actions” optimizations, and (2) ensuring tracked properties settings never appear for trigger nodes (backend doesn’t support them).
Changes:
- Broaden
hasVariableReferencedetection to catchvariables()when nested inside other expression functions. - Add/extend unit tests for nested variable reference detection and for preventing sequential InitializeVariable combining in such cases.
- Force
trackedPropertiessetting support tofalsefor triggers regardless of what connector manifests declare.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/designer/src/lib/core/parsers/test/combineSequentialInitializeVariables.spec.ts | Adds unit tests covering nested variables() detection and prevents combining when nested dependencies exist. |
| libs/designer/src/lib/core/parsers/ParseReduxAction.ts | Updates hasVariableReference logic used to block unsafe InitializeVariable combining. |
| libs/designer/src/lib/core/actions/bjsworkflow/settings.ts | Disables tracked properties support for triggers unconditionally. |
| libs/designer-v2/src/lib/core/parsers/test/combineSequentialInitializeVariables.spec.ts | Mirrors v1 tests for nested variable reference detection and non-combining behavior. |
| libs/designer-v2/src/lib/core/parsers/ParseReduxAction.ts | Mirrors v1 hasVariableReference update for designer-v2. |
| libs/designer-v2/src/lib/core/actions/bjsworkflow/settings.ts | Mirrors v1 tracked properties trigger restriction for designer-v2. |
takyyon
approved these changes
Feb 10, 2026
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Two bug fixes:
Nested variable reference detection (Fixes combine initialize variables logicapps#1447): The \hasVariableReference\ regex only matched @variables(...)\ directly, missing nested calls like @{substring(variables('x'), ...)}. This caused variables with inter-dependencies to be incorrectly combined into a single InitializeVariable action, breaking workflows at runtime.
Tracked properties on triggers (Fixes Some triggers show tracked properties in the settings, but saving errors out when set logicapps#798): Some connector manifests declared \ rackedProperties: {}\ without scope restrictions, causing the tracked properties setting to appear for triggers in the designer. The backend never supports tracked properties on triggers, so we now return \ alse\ early for triggers.
Impact of Change
Test Plan
Contributors
Screenshots/Videos
N/A - logic-only changes