fix(DesignerV2): Fixed dynamic height issue with Connector Browse panel

[rllyy97]

Commit Type

• feature - New functionality
• fix - Bug fix
• refactor - Code restructuring without behavior change
• perf - Performance improvement
• docs - Documentation update
• test - Test-related changes
• chore - Maintenance/tooling

Risk Level

• Low - Minor changes, limited scope
• Medium - Moderate changes, some user impact
• High - Major changes, significant user/system impact

Reason: Updated package is only used in once instance, and confirmed working in the scenario

What & Why

Fixed dynamic height issue with Connector Browse panel
Updated react-window package to 2.2.6
This updates the list component to auto-size height rather than us handling in manually (which had a bug)

Fixes #8759

Impact of Change

• Users: Users can now browse connectors on small screen sizes
• Developers: N/A
• System: N/A

Test Plan

• Unit tests added/updated
• E2E tests added/updated
• Manual testing completed
• Tested in:

// Styles files do not need test coverage

Contributors

@rllyy97

Screenshots/Videos

[github-actions]

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

✅ PR Title

• Current: fix(DesignerV2): Fixed dynamic height issue with Connector Browse panel
• Issue: None blocking — the title is clear, follows conventional commit prefix and describes the change.
• Recommendation: Optionally make it slightly more consistent with conventional commit case/style: fix(designer-v2): fix dynamic height in Connector Browse panel (not required).

---

✅ Commit Type

• Properly selected (fix).
• Note: Only one type selected which is correct.

---

⚠️ Risk Level

• Assessment: The PR body marks this as Low, and the repository label risk:low is present.
• Issue: From the code diff, this PR upgrades react-window from 1.x to 2.x and changes how the virtualized list is used (FixedSizeList -> List, API changes), removes container height management and CSS, and updates top-level package and lockfile. Dependency major-version upgrades with corresponding code changes are potentially breaking and have a broader impact than a purely cosmetic/fix-only change.
• Recommendation: Set the Risk Level to Medium in the PR body and add reasoning (dependency major upgrade, API surface change, potential for regressions in other components that may consume react-window or rely on previous behavior). If you believe it truly is Low, include a clear justification and a rollback/mitigation plan (how to revert the change quickly if regressions appear).

---

✅ What & Why

• Current: Fixed dynamic height issue with Connector Browse panel\nUpdated react-window package to 2.2.6\nThis updates the list component to auto-size height rather than us handling in manually (which had a bug)\nFixes #8759
• Issue: Good and concise.
• Recommendation: Add a one-line note about the nature of the react-window upgrade (major version) and any migration steps that were required so reviewers can quickly understand why the changes in code were necessary.

---

⚠️ Impact of Change

• The PR body states: Users: Users can now browse connectors on small screen sizes\nDevelopers: N/A\nSystem: N/A
• Issue: The Developers and System fields should not be N/A because you changed a dependency and types at the top-level/package. This can have developer impact (local dev environment, CI, other libs consuming react-window) and system/CI impact (lockfile changes, integrity differences).
• Recommendation: Update Impact of Change with concrete notes, for example:
  • Users: Connector Browse now handles dynamic height and works on small screens (as you have).
  • Developers: Bumped react-window to 2.2.6 and updated @types. If other areas rely on react-window 1.x API, they may need review. Ensure pnpm install and a full CI run pass locally. Add migration notes if applicable.
  • System: Updated pnpm-lock.yaml — CI will install new versions. Recommend verifying that CI images/agents don't cache an old lockfile state and that the integrity entries are correct.

---

✅ Test Plan

• Assessment: Good — unit tests were added (new test file for ConnectorBrowse) and manual testing completed.
• Recommendation: Consider adding a short note describing manual test scenarios (e.g., list of resolutions / browsers tested) and whether visual/regression/E2E tests were considered. If E2E was intentionally skipped, add a brief justification.

---

✅ Contributors

• Contributors section includes @rllyy97 — good.

---

✅ Screenshots/Videos

• Screenshot included — good for a visual UI fix.

---

Summary Table

Section	Status	Recommendation
Title	✅	(Optional) normalize casing to fix(designer-v2)
Commit Type	✅	No change needed
Risk Level	⚠️	Change PR risk to Medium and explain why
What & Why	✅	Add short note re: major-version migration
Impact of Change	⚠️	Expand Developer/System impacts (dependency bump, lockfile)
Test Plan	✅	Add manual test scenarios or E2E justification
Contributors	✅	No change needed
Screenshots/Videos	✅	No change needed

---

Final Notes & Actionable Recommendations

1. Update the PR Risk Level to Medium (checkbox in the PR body) and include a one-line explanation: "Major-version dependency bump (react-window 1.x -> 2.x) and API migration; potential for regressions beyond this component." This should match the risk:low label currently present — please update the label to risk:medium as well.
2. Expand the Impact of Change section:
   • Developers: note the dependency and type change, any local dev steps (pnpm install, rebuild storybook/test), and expected CI changes.
   • System: mention lockfile changes and CI verification.
3. Add a short manual test checklist in Test Plan (e.g., "Verify connector browse at 320px/768px/1366px, keyboard navigation, memory/perf smoke test"). If E2E is not feasible now, explain why and include any planned follow-up.
4. Ensure CI passes (install, build, tests). Because the lockfile and package versions changed, run a local pnpm install and full test matrix to confirm no transitive issues.
5. Optionally add a short migration comment in the PR noting what API differences required the code change (so reviewers unfamiliar with react-window 2.x can quickly verify).

Please update the PR title/body with the risk change and the additional items above, then re-submit. Thank you for the thorough tests and the clear description — the change looks well-implemented but warrants a Medium risk classification due to the dependency major upgrade.

---

Last updated: Fri, 13 Feb 2026 22:32:26 GMT

[Copilot]

Pull request overview

Fixes the Connector Browse panel’s dynamic height/virtualized list behavior by migrating to a newer react-window API and removing manual container height measurement.

Changes:

• Updated react-window (and its types) to newer major versions.
• Replaced FixedSizeList + manual resize/height tracking with a List component intended to auto-size.
• Removed browse panel grid container styling previously enforcing layout constraints.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.

File	Description
package.json	Bumps react-window and @types/react-window versions at the repo level.
libs/designer-v2/package.json	Aligns react-window dependency version for the designer-v2 package.
libs/designer-v2/src/lib/ui/panel/recommendation/browse/connectorBrowse.tsx	Switches virtualization implementation from FixedSizeList to List and removes manual height logic.
libs/designer-v2/src/lib/ui/panel/recommendation/browse/styles/ConnectorBrowse.styles.ts	Removes container grid styles previously constraining height/overflow.

Files not reviewed (1)

• pnpm-lock.yaml: Language not supported

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage check completed. See workflow run for details.

[github-actions]

📊 Coverage Check

The following changed files need attention:

⚠️ libs/designer-v2/src/lib/ui/panel/recommendation/browse/connectorBrowse.tsx - 77% covered (needs improvement)

Please add tests for the uncovered files before merging.