feat(DesignerV2): Added time filtering for RunHistory panel#8813
feat(DesignerV2): Added time filtering for RunHistory panel#8813
Conversation
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | Keep, or change to present tense (Add) if you prefer conventional commit tone. |
| Commit Type | ✅ | Correct (feature). |
| Risk Level | PR marks Medium. I advise High due to dependency and pnpm-lock.yaml churn — call this out and/or limit lockfile changes. | |
| What & Why | ✅ | Expand with files changed and list new deps. |
| Impact of Change | Expand Developers/System sections to mention deps, lockfile, and CI implications. | |
| Test Plan | ✅ | Add test command and file path, explain absence of E2E or plan for E2E. |
| Contributors | ✅ | OK — add any additional reviewers/contributors if applicable. |
| Screenshots/Videos | ✅ | Good. |
Final Notes & Actionable Steps
- Update PR body to explicitly call out the dependency additions and the large pnpm-lock.yaml changes. If those lockfile changes are expected (monorepo dependency upgrades), say so and explain why they were included here rather than in a separate dependency bump PR.
- If the lockfile changes are accidental/noise (e.g., regenerated by a different pnpm version or local environment), please regenerate the lockfile locally and attempt to minimize unrelated changes, or split dependency changes into a separate, focused PR. This will reduce risk and speed review.
- Add a short note in Test Plan with the unit test file path and how to run tests locally (command and any setup required) and ensure CI passes all suites. If you intend to keep the risk as Medium, add a clear explanation of why the lockfile churn is safe and list the CI results.
- Consider changing PR title to present-tense (
Add) if you follow conventional commits strictly — optional.
If you update the PR body with the requested clarifications (especially around dependencies/lockfile), and/or mark the PR with risk:high so it matches the advised risk, I will re-check quickly and confirm.
Thank you for the thorough work and for adding comprehensive unit tests — they look well structured and cover the new time-filter behaviors.
Last updated: Fri, 13 Feb 2026 20:43:45 GMT
There was a problem hiding this comment.
Pull request overview
This PR adds time filtering capabilities to the Run History panel in Designer V2, addressing issue #8615 where users needed datetime filtering to avoid manually paginating through run history results. The implementation provides preset time range filters (24h, 48h, 7d, 14d, 30d) and a custom range option with date/time pickers. All filters are now hidden behind a collapsible toggle button for better UI organization.
Changes:
- Added time interval filtering with preset ranges and custom date/time selection
- Reorganized filters behind a toggle button to reduce UI clutter
- Added mount node for Fluent UI compat components (DatePicker/TimePicker)
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| libs/designer-v2/package.json | Added dependencies for @fluentui/react-datepicker-compat and @fluentui/react-timepicker-compat |
| libs/designer-v2/src/lib/core/DesignerProvider.tsx | Added mount node div for Fluent UI compat components |
| libs/designer-v2/src/lib/ui/styles.less | Added styles for fluent-compat-component-mount with z-index positioning |
| libs/designer-v2/src/lib/ui/panel/runHistoryPanel/runHistoryPanel.styles.ts | Added styles for filter container, toggle button, and small input fields |
| libs/designer-v2/src/lib/ui/panel/runHistoryPanel/runHistoryPanel.tsx | Implemented time filtering logic, UI controls for date/time pickers, and filter toggle functionality |
| Localize/lang/strings.json | Added localization strings for time range labels, placeholders, and filter options |
libs/designer-v2/src/lib/ui/panel/runHistoryPanel/runHistoryPanel.tsx
Outdated
Show resolved
Hide resolved
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
|
📊 Coverage check completed. See workflow run for details. |
Commit Type
Risk Level
What & Why
Added time filtering for run history panel.
Users now have a few options for preset time filters like 24h, 7d, or custom.
Custom enables additional date and time pickers for start / end timeframes.
With the additional filtering, I moved all run filters behind a filtering button to show / hide the filters.
Fixes #8615
Impact of Change
Test Plan
Contributors
@rllyy97
Screenshots/Videos