Skip to content

feat(DesignerV2): Added time filtering for RunHistory panel#8813

Merged
rllyy97 merged 3 commits intomainfrom
riley/run-history-time-picker
Feb 13, 2026
Merged

feat(DesignerV2): Added time filtering for RunHistory panel#8813
rllyy97 merged 3 commits intomainfrom
riley/run-history-time-picker

Conversation

@rllyy97
Copy link
Contributor

@rllyy97 rllyy97 commented Feb 13, 2026

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Added time filtering for run history panel.
Users now have a few options for preset time filters like 24h, 7d, or custom.
Custom enables additional date and time pickers for start / end timeframes.
With the additional filtering, I moved all run filters behind a filtering button to show / hide the filters.

Fixes #8615

Impact of Change

  • Users: Users will be able to filter their runs by timeframe.
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

@rllyy97

Screenshots/Videos

image image

@rllyy97 rllyy97 added the risk:low Low risk change with minimal impact label Feb 13, 2026
Copilot AI review requested due to automatic review settings February 13, 2026 19:33
@github-actions
Copy link

github-actions bot commented Feb 13, 2026

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: feat(DesignerV2): Added time filtering for RunHistory panel
  • Issue: Minor style nit: conventional commit-style titles typically use present tense (e.g., Add vs Added). The title is otherwise clear and descriptive.
  • Recommendation: Consider: feat(DesignerV2): Add time filtering for RunHistory panel (keeps intent but matches conventional commit tone). Keep the scope (DesignerV2) and short summary.

Commit Type

  • Properly selected (feature). Only one option is checked in the PR body.
  • Note: If this PR contains additional unrelated work later, please mark multiple types or split the work; currently this is correct.

⚠️ Risk Level

  • Assessment: The PR body marks the change as Medium and the repo has the label risk:medium. However, based on the code diff there are large dependency and lockfile changes (new Fluent UI compat packages added in package.json: @fluentui/react-datepicker-compat, @fluentui/react-timepicker-compat and very large pnpm-lock.yaml churn across many packages and integrity values). There are also 1759 additions / 727 deletions across 8 files and a new large unit test file.
  • Recommendation: I advise increasing the risk to High because dependency and lockfile changes can have broad, cross-cutting effects on builds, CI, and runtime behavior. Please either:
    • explicitly justify the lockfile changes in the PR description (why so many entries changed), run a full CI/integration run, and add a risk:high label; or
    • reduce lockfile churn (regenerate only the entries required for this change) and isolate the dependency additions to a minimal set so the PR can stay at medium risk.

Note: Because my advised risk is higher than the submitter's selected risk, please call this out in the PR description and the team should perform a broader CI + integration validation before merge.


What & Why

  • Current: "Added time filtering for run history panel. Users now have a few options for preset time filters like 24h, 7d, or custom. Custom enables additional date and time pickers for start / end timeframes. With the additional filtering, I moved all run filters behind a filtering button to show / hide the filters. Fixes "new logic Apps experience" missing datetime filtering on run history. #8615"
  • Issue: The summary is succinct and clear. One improvement: call out specific files/components changed and user-visible behavior (you mostly did). Also mention dependency additions and that new unit tests were added.
  • Recommendation: Add a short line listing the main modified files (e.g., runHistoryPanel.tsx, styles, DesignerProvider, package.json, pnpm-lock.yaml, new test file) and the new deps. Example addition to the body: "Also added @fluentui/react-datepicker-compat and @fluentui/react-timepicker-compat and a compatibility mount node to DesignerProvider to render the compat components." This helps reviewers understand scope at a glance.

⚠️ Impact of Change

  • Issue: The PR body marks Developers/System as N/A. While end-user impact is clear, there are developer and system impacts to call out because of new dependencies + lockfile changes.
  • Recommendation: Expand the Impact section to include:
    • Users: Users can filter runs by timeframe (already present). Good.
    • Developers: Note the added dependencies (datepicker/timepicker compat packages), new mounting node (#fluent-compat-component-mount), and new styles.less entry. Call out that dependent components and build may require rebuilt lockfile and that other packages were updated in the lockfile.
    • System: Mention the lockfile changes and recommend running full CI and smoke tests; include that these package/lockfile changes might require a clean install in CI and may affect bundle size.

Test Plan

  • Assessment: The PR body claims unit tests added and manual testing completed. The diff includes a new test file: libs/designer-v2/src/lib/ui/panel/runHistoryPanel/test/runHistoryPanel.spec.tsx — so the claim is accurate.
  • Recommendation: Great. Please add a short note in the Test Plan listing the new unit test file path and any commands to run them (e.g., pnpm -w test or pnpm --filter libs/designer-v2 test) and whether CI passes are expected. If no E2E tests were added, briefly explain why (e.g., covered by unit tests + manual smoke test). If an integration/e2e test is appropriate for the date/time pickers, please consider adding one or documenting follow-up work.

Contributors

  • Assessment: Contributors listed (@rllyy97). Good.
  • Note: If others reviewed or helped (PM, designer), add them as contributors or mention them in the body.

Screenshots/Videos

  • Assessment: Screenshots are provided in the PR body. Good for UI changes.

Summary Table

Section Status Recommendation
Title Keep, or change to present tense (Add) if you prefer conventional commit tone.
Commit Type Correct (feature).
Risk Level ⚠️ PR marks Medium. I advise High due to dependency and pnpm-lock.yaml churn — call this out and/or limit lockfile changes.
What & Why Expand with files changed and list new deps.
Impact of Change ⚠️ Expand Developers/System sections to mention deps, lockfile, and CI implications.
Test Plan Add test command and file path, explain absence of E2E or plan for E2E.
Contributors OK — add any additional reviewers/contributors if applicable.
Screenshots/Videos Good.

Final Notes & Actionable Steps

  1. Update PR body to explicitly call out the dependency additions and the large pnpm-lock.yaml changes. If those lockfile changes are expected (monorepo dependency upgrades), say so and explain why they were included here rather than in a separate dependency bump PR.
  2. If the lockfile changes are accidental/noise (e.g., regenerated by a different pnpm version or local environment), please regenerate the lockfile locally and attempt to minimize unrelated changes, or split dependency changes into a separate, focused PR. This will reduce risk and speed review.
  3. Add a short note in Test Plan with the unit test file path and how to run tests locally (command and any setup required) and ensure CI passes all suites. If you intend to keep the risk as Medium, add a clear explanation of why the lockfile churn is safe and list the CI results.
  4. Consider changing PR title to present-tense (Add) if you follow conventional commits strictly — optional.

If you update the PR body with the requested clarifications (especially around dependencies/lockfile), and/or mark the PR with risk:high so it matches the advised risk, I will re-check quickly and confirm.

Thank you for the thorough work and for adding comprehensive unit tests — they look well structured and cover the new time-filter behaviors.


Last updated: Fri, 13 Feb 2026 20:43:45 GMT

@rllyy97 rllyy97 added risk:medium Medium risk change with potential impact and removed risk:low Low risk change with minimal impact labels Feb 13, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds time filtering capabilities to the Run History panel in Designer V2, addressing issue #8615 where users needed datetime filtering to avoid manually paginating through run history results. The implementation provides preset time range filters (24h, 48h, 7d, 14d, 30d) and a custom range option with date/time pickers. All filters are now hidden behind a collapsible toggle button for better UI organization.

Changes:

  • Added time interval filtering with preset ranges and custom date/time selection
  • Reorganized filters behind a toggle button to reduce UI clutter
  • Added mount node for Fluent UI compat components (DatePicker/TimePicker)

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
libs/designer-v2/package.json Added dependencies for @fluentui/react-datepicker-compat and @fluentui/react-timepicker-compat
libs/designer-v2/src/lib/core/DesignerProvider.tsx Added mount node div for Fluent UI compat components
libs/designer-v2/src/lib/ui/styles.less Added styles for fluent-compat-component-mount with z-index positioning
libs/designer-v2/src/lib/ui/panel/runHistoryPanel/runHistoryPanel.styles.ts Added styles for filter container, toggle button, and small input fields
libs/designer-v2/src/lib/ui/panel/runHistoryPanel/runHistoryPanel.tsx Implemented time filtering logic, UI controls for date/time pickers, and filter toggle functionality
Localize/lang/strings.json Added localization strings for time range labels, placeholders, and filter options

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@rllyy97 rllyy97 enabled auto-merge (squash) February 13, 2026 20:32
@github-actions
Copy link

📊 Coverage check completed. See workflow run for details.

@rllyy97 rllyy97 merged commit 216718e into main Feb 13, 2026
13 checks passed
@rllyy97 rllyy97 deleted the riley/run-history-time-picker branch February 13, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"new logic Apps experience" missing datetime filtering on run history.

3 participants